Fisheye on dd-firmware/firmware/App/Modes/FPModes https://devapps.diality.us/changelog/~br%3DLDT-3984-dd-fp-defeatured-fixes/dd-firmware/firmware/App/Modes/FPModes Recent activity in "dd-firmware" under directory /firmware/App/Modes/FPModes LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers resumed Fri, 24 Apr 2026 22:17:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3904-1: closed by Raghu Kallala Wed, 22 Apr 2026 11:40:13 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3904-1 ]]> LEAHI-DD-FIRMWARE-LDT-3904-1: reviewers finished Wed, 22 Apr 2026 11:39:46 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-3904-1 LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes ]]> LEAHI-DD-FIRMWARE-LDT-3904-1: reviewers finished Tue, 21 Apr 2026 14:24:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3904-1 LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: closed by Dara Navaei Mon, 20 Apr 2026 09:51:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: reviewers finished Mon, 20 Apr 2026 09:23:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: comment by Michael Garthwaite "fixed" Mon, 20 Apr 2026 06:52:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3984-1

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3984-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 wi... Fri, 17 Apr 2026 18:02:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: comment by Vinayakam Mani "Align the comments." Fri, 17 Apr 2026 17:17:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3984-1

Align the comments.

]]> LEAHI-DD-FIRMWARE-LDT-3984-1: started by Dara Navaei Fri, 17 Apr 2026 17:13:47 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): LDT-3984: fixes for defeatured operation Fri, 17 Apr 2026 14:42:25 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=65fc5c36624e283aca69aae3f35542ecfec0f24c https://devapps.diality.us/changelog/dd-firmware?cs=65fc5c36624e283aca69aae3f35542ecfec0f24c Michael Garthwaite committed 65fc5c3 on branch LDT-3749-ability-to-set-operation-sub-mode-latest, LDT-3904-opmode-the-operation-mode-broad and 6 more in dd-firmware LDT-3984: fixes for defeatured operation

· /firmware/App/Controllers/PermeateTank.c (-29, +35) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.c (-4, +4) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c (-1, +2) | History | Source | Diff
· /firmware/App/Modes/FPModes/StateFlushFilterDefeatured.c (-14, +21) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3904-1: comment by Raghu Kallala "COMM_BUFFER_OUT_CAN_FP_BROADCAST sendEvent c..." Wed, 15 Apr 2026 13:09:32 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1/#c28399 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1/#c28399 Raghu Kallala replied to Michael Garthwaite in LEAHI-DD-FIRMWARE-LDT-3904-1

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

]]> LEAHI-DD-FIRMWARE-LDT-3904-1: comment by Michael Garthwaite "Do we know which channel this event will be sen..." Wed, 15 Apr 2026 11:05:58 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1/#c28379 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1/#c28379 Michael Garthwaite commented on LEAHI-DD-FIRMWARE-LDT-3904-1

Do we know which channel this event will be sent on?

]]> LEAHI-DD-FIRMWARE-LDT-3904-1: started by Dara Navaei Tue, 14 Apr 2026 11:17:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3904-1 ]]> LEAHI-DD-FIRMWARE-LDT-3677-1: closed by Raghu Kallala Fri, 10 Apr 2026 10:39:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3677-1 ]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 10 Apr 2026 10:38:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=6c1e038c32aae95cd5649320d12c1d7239834425 https://devapps.diality.us/changelog/dd-firmware?cs=6c1e038c32aae95cd5649320d12c1d7239834425 Dara Navaei committed 6c1e038 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2008-v2-conductivity-sensors-CLEAN and 15 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/FPModes/FPOperationModes.c (-1, +1) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3677-1: reviewers finished Fri, 10 Apr 2026 10:02:54 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 Sean Nash and Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-3677-1 LEAHI-DD-FIRMWARE-LDT-3677_Request: add SW config to enable defeatured IOFP control in the IOFP FW ]]> LEAHI-DD-FIRMWARE-LDT-3677-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3677_Request: add SW config ... Fri, 10 Apr 2026 09:02:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 Michael Garthwaite joined LEAHI-DD-FIRMWARE-LDT-3677-1 LEAHI-DD-FIRMWARE-LDT-3677_Request: add SW config to enable defeatured IOFP control in the IOFP FW ]]> LEAHI-DD-FIRMWARE-LDT-3677-1: started by Dara Navaei Fri, 10 Apr 2026 08:57:03 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3677-1 ]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): LDT-3677 added fix to reset value when TC is disabled for Boost pump and defeatured Fri, 10 Apr 2026 08:46:08 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=24f8a28428bf87b7bf4a1e0ebcfba33ee93fe499 https://devapps.diality.us/changelog/dd-firmware?cs=24f8a28428bf87b7bf4a1e0ebcfba33ee93fe499 Raghu Kallala committed 24f8a28 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2008-v2-conductivity-sensors-CLEAN and 16 more in dd-firmware LDT-3677 added fix to reset value when TC is disabled for Boost pump and defeatured

· /firmware/App/Modes/FPModes/FPOperationModes.c (-0, +10) | History | Source | Diff
]]>