· /firmware/App/Monitors/Level.c

(-1, +1)

| History

| Source

| Diff

]]> Fri, 01 May 2026 10:02:07 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-3 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-3 ]]> Thu, 30 Apr 2026 20:50:05 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=f37bfe2eaf910104d6edfcf46a9771871fbfbc69 https://devapps.diality.us/changelog/dd-firmware?cs=f37bfe2eaf910104d6edfcf46a9771871fbfbc69 Michael Garthwaite committed f37bfe2 on branch LDT-4000-hdf-fw-implementation-1, develop in dd-firmware LDT-4000: changed beta 2.0 test config to beta 1.9 test config

· /firmware/App/Controllers/Heaters.c	(-7, +7)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-11, +11)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-24, +22)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-12, +12)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-52, +32)	| History	| Source	| Diff

]]> Thu, 30 Apr 2026 18:40:02 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=11fcfaffab49f00f358124c8c285a821632eba24 https://devapps.diality.us/changelog/dd-firmware?cs=11fcfaffab49f00f358124c8c285a821632eba24 Michael Garthwaite committed 11fcfaf on branch LDT-4000-hdf-fw-implementation-1, develop in dd-firmware LDT-4000: substitution pump implementation and fixes.

· /firmware/App/Controllers/SubstitutionPump.c	(-0, +554)	| History	| Source
· /firmware/App/Controllers/SubstitutionPump.h	(-0, +73)	| History	| Source
· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-6, +0)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +91)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.h	(-0, +4)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +2)	| History	| Source	| Diff

]]> Thu, 30 Apr 2026 14:23:11 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> Thu, 30 Apr 2026 13:57:01 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=2d295ca85f19e95da42476a57ca6b4496baf980a https://devapps.diality.us/changelog/dd-firmware?cs=2d295ca85f19e95da42476a57ca6b4496baf980a Dara Navaei committed 2d295ca on branch LDT-3272-software-update---dd-firmware, LDT-3978-fix-for-bicart-upper-threshold-pressure and 5 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 30 Apr 2026 13:42:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> Thu, 30 Apr 2026 10:58:33 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28761 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28761 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3978-1

a time out for decaying D66 pressure to 3 PSI after D65 closed

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

· /firmware/App/Monitors/Level.c

(-2, +2)

| History

| Source

| Diff

]]> Tue, 28 Apr 2026 21:30:36 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=902889c30391b6ca8c9f19adfd3c841c86a5d49f https://devapps.diality.us/changelog/dd-firmware?cs=902889c30391b6ca8c9f19adfd3c841c86a5d49f Vendor - TEL - Sameer Poyil committed 902889c on branch LDT-3272-software-update---dd-firmware, LDT-3978-fix-for-bicart-upper-threshold-pressure and 6 more in dd-firmware LDT-3978 firmware implementation for ocean spray

· /firmware/App/Controllers/BalancingChamber.c	(-7, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-87, +77)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-4, +4)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 12:08:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28728 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28728 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Remove space after 'Supply'.

Align the value declaration indentation.

looks you are already checking this state in a line above.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-4, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-5, +2)	| History	| Source	| Diff

]]> Mon, 27 Apr 2026 09:18:56 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4000-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4000-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4000-1 ]]> Sun, 26 Apr 2026 12:45:03 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3972-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3972-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3972-1 LEAHI-DD-FIRMWARE-LDT-3972_Water Treatment and Degassing - FW Iteration - 1/4: ]]> Sun, 26 Apr 2026 12:44:59 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3972-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3972-1 Sean Nash added Vendor - TEL - Arpita Srivastava and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3972-1 LEAHI-DD-FIRMWARE-LDT-3972_Water Treatment and Degassing - FW Iteration - 1/4: ]]> Sun, 26 Apr 2026 12:42:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28652 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28652 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Declare local variables at top of scope.

Add space between ( and ?

Remove blank line.

Why redeclare result?