updated

updated

updated

moved.

updated

Move below Messaging.h to keep list in alphabetical order.

Same here. Let's use only D29.

Suppose to use D74, Instead of D17 (for Control only).

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Missing Comment.

Same as above.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

it shouldn't be the default value

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	| History	| Source	| Diff

]]> Thu, 25 Jun 2026 15:04:08 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4612-1 LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1: ]]> Thu, 25 Jun 2026 12:29:46 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=9d48b0592dc3d0bd7598bea7a470f4ac274cb86e https://devapps.diality.us/changelog/dd-firmware?cs=9d48b0592dc3d0bd7598bea7a470f4ac274cb86e Vendor - TEL - Sameer Poyil committed 9d48b05 on branch LDT-3902-BC-switch-only-min-flow-rate, LDT-4011-isolated-uf-dd---fw-implementat-temp-comp and 10 more in dd-firmware LDT-4612 mixing control updates

· /firmware/App/Controllers/MixingControl.c

(-0, +2)

| History

| Source

| Diff

]]> Wed, 24 Jun 2026 16:54:43 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=a6ead936473ef260bbd330050fcf7e1b10120175 https://devapps.diality.us/changelog/dd-firmware?cs=a6ead936473ef260bbd330050fcf7e1b10120175 Vendor - TEL - Sameer Poyil committed a6ead93 on branch LDT-3902-BC-switch-only-min-flow-rate, LDT-4011-isolated-uf-dd---fw-implementat-temp-comp and 10 more in dd-firmware LDT-4612 addressed review comments

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-80, +72)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +4)	| History	| Source	| Diff

]]> Wed, 24 Jun 2026 14:53:17 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-4409-2 ]]> Wed, 24 Jun 2026 14:47:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1/#c30133 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1/#c30133 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Space after if.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

remove empty space after d66pressure variable. or match the indent to previous statement.

Add a TODO comment (remove later): this should be handled in IO/FP module.

Update comment.

Add comment.

Depressurize?

Fix the typo.