Fisheye on dd-firmware/firmware/App/DDCommon.h

LEAHI-DD-FIRMWARE-LDT-4246-1: started by Dara Navaei

Dara Navaei — Wed, 06 May 2026 08:48:07 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4246-1

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this flag."

Vinayakam Mani — Tue, 05 May 2026 12:35:33 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this flag.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this code."

Vinayakam Mani — Tue, 05 May 2026 12:31:12 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this code.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this condition to apply the speed for BC..."

Vinayakam Mani — Tue, 05 May 2026 11:57:09 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this condition to apply the speed for BC switch only as well.

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Tue, 05 May 2026 11:12:08 -0700

Dara Navaei committed afb0935 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Check the else portion and do the required chan..."

Vinayakam Mani — Tue, 05 May 2026 10:20:37 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Check the else portion and do the required changes.

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Tue, 05 May 2026 07:22:18 -0700

Dara Navaei committed d89f8b9 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Name something similar to 'BCSwitchingBasedOnCl..."

Vinayakam Mani — Mon, 04 May 2026 16:14:18 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "I guess, all these checks should be moved to Fi..."

Vinayakam Mani — Mon, 04 May 2026 16:02:37 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

I guess, all these checks should be moved to FillEndState.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "after one state of BC switching completed. upda..."

Vinayakam Mani — Mon, 04 May 2026 15:51:27 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

after one state of BC switching completed. update the next comment as well.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "Should we add a TODO to remove this one as well..."

Vendor - TEL - Arpita Srivastava — Mon, 04 May 2026 09:59:06 -0700

Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Should we add a TODO to remove this one as well?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "If we are removing this call, then where are we..."

Vendor - TEL - Arpita Srivastava — Mon, 04 May 2026 09:57:11 -0700

Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "Please update the function name : testDDFloater..."

Vendor - TEL - Arpita Srivastava — Mon, 04 May 2026 09:44:11 -0700

Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Please update the function name : testDDFloaterLevelStateOverride

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Mon, 04 May 2026 07:37:42 -0700

Dara Navaei committed e8c6150 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

LEAHI-DD-FIRMWARE-LDT-3963-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - F...

Sun, 03 May 2026 23:45:17 -0700

Sean Nash added Michael Garthwaite , Vendor - TEL - Arpita Srivastava and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3963-1

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Why are we removing this TODO comment? It look..."

Sean Nash — Sun, 03 May 2026 23:08:20 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Why are we removing this TODO comment? It looks like we should keep it.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Do we need TODO comments to restore these alarm..."

Sean Nash — Sun, 03 May 2026 23:06:56 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Do we need TODO comments to restore these alarms later?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "What is the point of this message?"

Sean Nash — Sun, 03 May 2026 23:06:01 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

What is the point of this message?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Looks like we need a TODO comment to restore th..."

Sean Nash — Sun, 03 May 2026 23:01:28 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Looks like we need a TODO comment to restore these checks later.

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 01 May 2026 13:58:32 -0700

Dara Navaei committed 2ed5e7c on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 01 May 2026 12:05:02 -0700

Dara Navaei committed b4f9e54 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 01 May 2026 11:21:23 -0700

Dara Navaei committed 74861ca on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 01 May 2026 10:15:09 -0700

Dara Navaei committed 198e279 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 01 May 2026 08:45:43 -0700

Dara Navaei committed 72b58d8 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 30 Apr 2026 22:07:58 -0700

Dara Navaei committed 1c618ce on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 30 Apr 2026 21:17:14 -0700

Dara Navaei committed 44f482f on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 30 Apr 2026 21:06:47 -0700

Dara Navaei committed eb9e523 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 30 Apr 2026 20:29:17 -0700

Dara Navaei committed 7983df6 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): Merge branch 'LDT-4000-hdf-fw-implementation-1' into develop

Michael Garthwaite — Thu, 30 Apr 2026 20:27:39 -0700

Michael Garthwaite committed 27dab35 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

Merge branch 'LDT-4000-hdf-fw-implementation-1' into develop

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/DDCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3978-1: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 30 Apr 2026 14:23:11 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-3978-1