It's present in fp_defs as FPRecoveryOptions

· /leahi_dialin/fp/modules/levels.py

(-1, +1)

| History

| Source

| Diff

]]> Tue, 28 Apr 2026 09:17:20 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1/#c28712 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1/#c28712 Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3984-1

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

· /leahi_dialin/common/dd_defs.py	(-5, +5)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-3, +2)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/levels.py	(-1, +3)	| History	| Source	| Diff

]]> Sun, 26 Apr 2026 14:46:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1/#c28685 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1/#c28685 Sean Nash commented on LEAHI-DIALIN-LDT-3218-1

Should this be an enumeration somewhere?

· /leahi_dialin/common/msg_ids.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-0, +27)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/levels.py	(-3, +5)	| History	| Source	| Diff

]]> Thu, 23 Apr 2026 08:02:29 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 Dara Navaei started review LEAHI-DIALIN-LDT-3984-1 ]]> Mon, 30 Mar 2026 14:33:37 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-696-1 ]]> Mon, 30 Mar 2026 11:30:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> Mon, 30 Mar 2026 09:39:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> Thu, 26 Mar 2026 12:16:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 Dara Navaei started review LEAHI-DIALIN-LDT-3218-1 ]]> Thu, 26 Mar 2026 11:16:40 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> Thu, 26 Mar 2026 10:30:02 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

Added

Add a TODO comment to change the message once implemented in FW

removed duplicate

ROPump is repeated

RECOVERY_STATES

· /leahi_dialin/common/dd_defs_proxy.py	(-41, +41)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-7, +47)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-30, +33)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-39, +39)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/boost_pump.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-1, +1)	| History	| Source	| Diff

]]> Wed, 18 Mar 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-2 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> Tue, 17 Mar 2026 07:05:16 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-2

update params

· /leahi_dialin/dd/modules/heaters.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/valves.py	(-3, +3)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/valves.py	(-3, +3)	| History	| Source	| Diff

]]>