It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

Add doxygen comments to the right of each structure field.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

Add blank line before return statement.

Keep this blank line above group header.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

do we need this block?

update the comment as required: ml or L?

Please add the min and max for tmp as well in the outputs.

rejReason = INVALID REQUEST FORMAT

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Add a doxygen comment above this array.

Add a doxygen comment above this array (similar to structures).

Add a doxygen comment above structure for the whole structure (see structure above for example).

Add a doxygen comment for this definition.

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

Looks like comment for 208 and 223 are swapped?