· /leahi_dialin/common/msg_ids.py	(-0, +5)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs.py	(-0, +24)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/substitution_pump.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/hemodiafiltration.py	(-0, +183)	| History	| Source
· /leahi_dialin/td/treatment_delivery.py	(-0, +2)	| History	| Source	| Diff

]]> Wed, 15 Jul 2026 15:04:04 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4611-5 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4611-5 Dara Navaei started review LEAHI-DIALIN-LDT-4611-5 ]]> Mon, 13 Jul 2026 14:46:50 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 Tiffany Mejia and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3735-1 LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Sun, 12 Jul 2026 23:43:02 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30436 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30436 Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

• with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
• with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

• with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
• with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

fixed. thanks!

fixed. thanks

· /leahi_dialin/dd/modules/conductivity_sensors.py	(-0, +5)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-0, +2)	| History	| Source	| Diff

]]> Wed, 01 Jul 2026 14:40:41 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4734-1/#c30322 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4734-1/#c30322 Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4734-1

Add uncompensated conductivity to the init too

Add uncompensated conductivity to the init too

· /leahi_dialin/common/dd_defs.py	(-3, +5)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-0, +5)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-14, +8)	| History	| Source	| Diff

]]> Wed, 01 Jul 2026 12:33:22 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30308 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30308 Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

RESOLVED for now.

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.