right now pre and post are same. make a TODO to update post later

its mixing control interval

could you document th math behind the calculation also

What is 4 (or 2)? Should be #define or enum or const.

Same as above.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

it shouldn't be the default value

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

This should return POST conductivity.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

Init PI Controls missing here.

13734.87F

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

both acid and bicarb mix volume

Add MULTIPLIER at the end.

Initialize at init function.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Lets remove this.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Tue, 16 Jun 2026 12:50:12 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=09c28b39101fef90f9c667fa18f6af711de1172b https://devapps.diality.us/changelog/dd-firmware?cs=09c28b39101fef90f9c667fa18f6af711de1172b Dara Navaei committed 09c28b3 on branch LDT-3735-non-volatile-memory, LDT-3902-BC-switch-only-min-flow-rate and 14 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Thu, 11 Jun 2026 14:28:08 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=049d228aac586b500cdf73df3fd126fce6eaa741 https://devapps.diality.us/changelog/dd-firmware?cs=049d228aac586b500cdf73df3fd126fce6eaa741 Dara Navaei committed 049d228 on branch LDT-3735-non-volatile-memory, LDT-3902-BC-switch-only-min-flow-rate and 18 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Fri, 05 Jun 2026 13:17:59 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=48ec967966214cb3e21ee4338d9aa751c626bac1 https://devapps.diality.us/changelog/dd-firmware?cs=48ec967966214cb3e21ee4338d9aa751c626bac1 Dara Navaei committed 48ec967 on branch LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3735-non-volatile-memory and 22 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Mon, 01 Jun 2026 17:35:51 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=605b476dfac4d79f280dbd6a513abcca43552be1 https://devapps.diality.us/changelog/dd-firmware?cs=605b476dfac4d79f280dbd6a513abcca43552be1 Dara Navaei committed 605b476 on branch LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3735-non-volatile-memory and 22 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Mon, 01 Jun 2026 17:35:07 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=0bcac6885c8461b05da276fd245b580b7339ddfd https://devapps.diality.us/changelog/dd-firmware?cs=0bcac6885c8461b05da276fd245b580b7339ddfd Dara Navaei committed 0bcac68 on branch LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3735-non-volatile-memory and 22 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.h	(-1, +1)	| History	| Source	| Diff

]]> Mon, 01 Jun 2026 17:35:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3958-1 ]]> Mon, 01 Jun 2026 17:18:47 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 Sean Nash and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3958-1 LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2: ]]>