· /firmware/App/Controllers/DryBiCart.c

(-2, +2)

| History

| Source

| Diff

]]> Thu, 18 Jun 2026 14:34:30 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=95b0e204056dd7ce173ca05d42e2712652682d06 https://devapps.diality.us/changelog/dd-firmware?cs=95b0e204056dd7ce173ca05d42e2712652682d06 Vendor - TEL - Sameer Poyil committed 95b0e20 on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4612 persistence on D66 updates

· /firmware/App/Controllers/DryBiCart.c

(-11, +8)

| History

| Source

| Diff

]]> Thu, 18 Jun 2026 13:53:24 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30011 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30011 Vinayakam Mani replied to Vendor - TEL - Arpita Srivastava in LEAHI-DD-FIRMWARE-LDT-4539-1

Looks On event handled later. One event should be fine for On condtion.

Space after 0

prevDryBicartState

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

prevBalChamberState?

· /firmware/App/Controllers/MixingControl.c	(-2, +10)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 10:21:35 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c29976 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c29976 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Should we also send an event when we start the heater?

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

· /firmware/App/Controllers/DryBiCart.c	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-1, +1)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +1)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 04:02:22 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4612-1 ]]> Wed, 17 Jun 2026 22:13:02 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=a08bda2a0610a27e3147fed72e1aca7b798a1bb0 https://devapps.diality.us/changelog/dd-firmware?cs=a08bda2a0610a27e3147fed72e1aca7b798a1bb0 Vendor - TEL - Sameer Poyil committed a08bda2 on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4612 fix for micing control integration issues

· /firmware/App/Controllers/DryBiCart.c	(-21, +18)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-3, +7)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:37:48 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=2fb7d785ee943a46e0c67deaf9fce1f9217e65be https://devapps.diality.us/changelog/dd-firmware?cs=2fb7d785ee943a46e0c67deaf9fce1f9217e65be Dara Navaei committed 2fb7d78 on branch LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Tue, 16 Jun 2026 13:37:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=145fd716a856f864f39fb0f9884865f6e45b9256 https://devapps.diality.us/changelog/dd-firmware?cs=145fd716a856f864f39fb0f9884865f6e45b9256 Dara Navaei committed 145fd71 on branch LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:35:13 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=71c51efd08a5140276e78f090fee5f1698f5b5f1 https://devapps.diality.us/changelog/dd-firmware?cs=71c51efd08a5140276e78f090fee5f1698f5b5f1 Vendor - TEL - Sameer Poyil committed 71c51ef on branch LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more in dd-firmware LDT-4409 drybicart and dialysate mixing firmware implementation

· /firmware/App/Monitors/Conductivity.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-4, +5)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:24:08 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Jashwant Gantyada and Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-4409-2 LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1: ]]> Tue, 16 Jun 2026 13:23:38 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=cabab4c56b6840c94126b71696d2c95011cb01a0 https://devapps.diality.us/changelog/dd-firmware?cs=cabab4c56b6840c94126b71696d2c95011cb01a0 Vendor - TEL - Sameer Poyil committed cabab4c on branch LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more in dd-firmware LDT-4409 addressed review comments

· /firmware/App/Controllers/DryBiCart.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +5)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:16:47 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-4409-2 LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1: ]]> Tue, 16 Jun 2026 12:50:12 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=09c28b39101fef90f9c667fa18f6af711de1172b https://devapps.diality.us/changelog/dd-firmware?cs=09c28b39101fef90f9c667fa18f6af711de1172b Dara Navaei committed 09c28b3 on branch LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Tue, 16 Jun 2026 12:49:19 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=3b64586791accd0b9e8d8978b40e2509bb86dfbe https://devapps.diality.us/changelog/dd-firmware?cs=3b64586791accd0b9e8d8978b40e2509bb86dfbe Dara Navaei committed 3b64586 on branch LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/SubstitutionPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 12:45:17 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=9fa1c3f498f776adfbf65b41408893196874d3ec https://devapps.diality.us/changelog/dd-firmware?cs=9fa1c3f498f776adfbf65b41408893196874d3ec Michael Garthwaite committed 9fa1c3f on branch LDT-4410-dialysate-composition-mixing-2, LDT-4612-dialysate-composition-integ and 2 more in dd-firmware Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into staging

]]> Tue, 16 Jun 2026 12:45:00 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=359af96e821153cb9b3a61e10d2793eaee562a77 https://devapps.diality.us/changelog/dd-firmware?cs=359af96e821153cb9b3a61e10d2793eaee562a77 Michael Garthwaite committed 359af96 on branch LDT-4410-dialysate-composition-mixing-2, LDT-4485-dd-conductivity-sensors-d17 and 3 more in dd-firmware LDT-4485: err fix

· /firmware/App/Monitors/Conductivity.c

(-0, +1)

| History

| Source

| Diff

]]> Tue, 16 Jun 2026 12:42:56 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=e3dc524ebfe8f63238e2d0ade858c0e2f98dfc73 https://devapps.diality.us/changelog/dd-firmware?cs=e3dc524ebfe8f63238e2d0ade858c0e2f98dfc73 Michael Garthwaite committed e3dc524 on branch LDT-4410-dialysate-composition-mixing-2, LDT-4485-dd-conductivity-sensors-d17 and 3 more in dd-firmware LDT-4485: err fix

· /firmware/App/Monitors/Conductivity.c

(-1, +1)

| History

| Source

| Diff

]]> Tue, 16 Jun 2026 12:41:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4485-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4485-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4485-1 ]]> Tue, 16 Jun 2026 11:55:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2/#c29958 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2/#c29958 Vinayakam Mani replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4409-2

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

· /firmware/App/Controllers/MixingControl.c

(-0, +1)

| History

| Source

| Diff

]]> Tue, 16 Jun 2026 11:09:38 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=39fbf9fd993d5e735092cf4ad802d58d0f92f7b1 https://devapps.diality.us/changelog/dd-firmware?cs=39fbf9fd993d5e735092cf4ad802d58d0f92f7b1 Vendor - TEL - Sameer Poyil committed 39fbf9f on branch LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more in dd-firmware LDT-4409 addressed review comments

· /firmware/App/Controllers/DryBiCart.c	(-10, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-0, +1)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 10:59:15 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4485-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4485-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-4485-1 LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently ]]> Tue, 16 Jun 2026 10:58:02 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4485-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4485-1 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-4485-1 LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently ]]>