Fisheye on td-firmware/firmware/App/Modes/ModeTreatment.h https://devapps.diality.us/changelog/~br%3DLDT-473-treatment-parameters-create-rx-latest/td-firmware/firmware/App/Modes/ModeTreatment.h Recent activity in "td-firmware" under directory /firmware/App/Modes/ModeTreatment.h LEAHI-TD-FIRMWARE-LDT-473-3: reviewers resumed Mon, 27 Apr 2026 08:08:51 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Sean Nash and Vinayakam Mani resumed reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "We can set bolus volume here now. These functi..." Sun, 26 Apr 2026 13:08:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28662 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28662 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Why does confirm msg have duration again? If U..." Sun, 26 Apr 2026 13:05:44 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28661 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28661 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "These are already in TxParams I believe." Sun, 26 Apr 2026 13:02:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28660 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28660 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

These are already in TxParams I believe.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Should these be moved to Services\TxParams?" Sun, 26 Apr 2026 13:01:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28659 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28659 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Should these be moved to Services\TxParams?

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Change 1 to TRUE" Sun, 26 Apr 2026 12:59:57 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28658 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28658 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Change 1 to TRUE

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Agree with name change, but I think BOOL was th..." Sun, 26 Apr 2026 12:58:24 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28656 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28656 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Agree with name change, but I think BOOL was the correct type. And BOOL is equivalent to U32 anyway so compiler won't care.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "I think these message handlers for editing trea..." Sun, 26 Apr 2026 12:56:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28655 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28655 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "These should probably be moved to Services\TxPa..." Sun, 26 Apr 2026 12:46:09 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28653 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28653 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

These should probably be moved to Services\TxParams.h because Messaging.c does not use them.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "See if we have already defined this stuff in Se..." Sun, 26 Apr 2026 12:48:19 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28654 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28654 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Raghu Kallala "Added to be consistent. Once institutional reco..." Fri, 17 Apr 2026 07:33:15 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28453 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28453 Raghu Kallala replied to Vinayakam Mani in LEAHI-TD-FIRMWARE-LDT-473-3

Added to be consistent. Once institutional records are implemented will store it in there instead of a macro

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: started by Dara Navaei Thu, 16 Apr 2026 19:32:48 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3970-1 ]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Vinayakam Mani "DO we need bicarb conversion factor as well?" Wed, 15 Apr 2026 11:33:42 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28385 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28385 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-473-3

DO we need bicarb conversion factor as well?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "preweight can be non-zero" Wed, 15 Apr 2026 09:45:49 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28370 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28370 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

preweight can be non-zero

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Add blank line after declarations." Tue, 14 Apr 2026 13:34:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28320 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28320 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Add blank line after declarations.

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Raghu Kallala "From what I see in UI, it is just a range value..." Wed, 08 Apr 2026 10:38:58 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28255 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28255 Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-3

From what I see in UI, it is just a range value not an enum/index

]]> LEAHI-TD-FIRMWARE-LDT-473-3: reviewers added to LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Cr... Mon, 06 Apr 2026 14:12:26 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Sean Nash added Vinayakam Mani to LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Is it an enum/index like Denali then?" Mon, 06 Apr 2026 13:37:21 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28244 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28244 Sean Nash replied to Raghu Kallala in LEAHI-TD-FIRMWARE-LDT-473-3

Is it an enum/index like Denali then?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Raghu Kallala "No we are not getting conv factor from UI on it..." Mon, 06 Apr 2026 12:42:53 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28243 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28243 Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-3

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Align comments." Mon, 06 Apr 2026 11:01:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28237 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28237 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Align comments.

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove this?" Mon, 06 Apr 2026 10:57:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28236 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28236 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove this?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove this?" Mon, 06 Apr 2026 10:57:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28235 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28235 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove this?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "F suffix." Mon, 06 Apr 2026 10:56:14 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28234 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28234 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

F suffix.

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Is bicarbonate also a conversion factor?" Mon, 06 Apr 2026 10:52:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28233 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28233 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Is bicarbonate also a conversion factor?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove the old enum now?" Mon, 06 Apr 2026 10:49:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28232 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28232 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove the old enum now?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: started by Dara Navaei Mon, 06 Apr 2026 10:16:18 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-473-3 ]]> LEAHI-TD-FIRMWARE-LDT-473-2: closed by Raghu Kallala Mon, 06 Apr 2026 10:04:42 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2 Raghu Kallala Closed LEAHI-TD-FIRMWARE-LDT-473-2 ]]> td-firmware (LDT-473-treatment-parameters-create-rx-latest): LDT-473 initial draft WIP new tx params message payload Mon, 06 Apr 2026 10:00:43 -0700 Raghu Kallala https://devapps.diality.us/changelog/td-firmware?cs=30e46b4f07697652455fa861bcaa18f3d60ae11f https://devapps.diality.us/changelog/td-firmware?cs=30e46b4f07697652455fa861bcaa18f3d60ae11f Raghu Kallala committed 30e46b4 on branch LDT-473-treatment-parameters-create-rx-latest in td-firmware LDT-473 initial draft WIP new tx params message payload

· /firmware/App/Modes/ModeStandby.c (-5, +6) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-8, +40) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.h (-2, +15) | History | Source | Diff
· /firmware/App/Modes/StateTxDialysis.c (-4, +5) | History | Source | Diff
· /firmware/App/Monitors/Pressures.c (-4, +4) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +3) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-5, +7) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-3, +1) | History | Source | Diff
· /firmware/App/Services/TxParams.c (-290, +627) | History | Source | Diff
· /firmware/App/Services/TxParams.h (-19, +26) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-3126-1: closed by Vendor - TEL - Varshini Nagabooshanam Thu, 12 Mar 2026 16:23:18 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3126-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3126-1 Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-TD-FIRMWARE-LDT-3126-1 ]]> LEAHI-TD-FIRMWARE-LDT-3126-1: reviewers resumed Thu, 12 Mar 2026 16:21:03 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3126-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3126-1 Vendor - TEL - Sameer Poyil and Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-3126-1 LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD ]]>