This reverts commit f43d59af8e69ef1459bafe91873ce41cf63a4a75, reversing

changes made to 7f56f07660862bc62524c506699193a7e5f48f96.

· /firmware/App/Controllers/BalancingChamber.c	(-304, +125)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-9, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-4, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-163, +61)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-13, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-51, +16)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-10, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-13, +0)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-4, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-0, +1)	| History	| Source	| Diff
… 9 more files in changeset.

]]> Wed, 29 Jul 2026 04:02:19 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5102-1 ]]> Wed, 24 Jun 2026 06:36:55 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> Wed, 06 May 2026 08:48:07 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> Fri, 17 Apr 2026 09:54:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3352-1 ]]> Fri, 17 Apr 2026 06:24:54 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=520b5b97e2a1a6d7af037e1144f1ffeb39153e3e https://devapps.diality.us/changelog/dd-firmware?cs=520b5b97e2a1a6d7af037e1144f1ffeb39153e3e Vendor - TEL - Sameer Poyil committed 520b5b9 on branch LDT-4246-fw-support-for-ui-demo, LDT-4873-request-add-config-to-disable-c-1 and 4 more in dd-firmware Merge branch LDT-2004-dialysate-composition-dosing-control--dd into develop

· /firmware/App/Controllers/BalancingChamber.c	(-14, +20)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-420, +467)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-5, +6)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +92)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 08:24:53 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=fd21f03d28eec499fb5c01bf595c57893db94406 https://devapps.diality.us/changelog/dd-firmware?cs=fd21f03d28eec499fb5c01bf595c57893db94406 Dara Navaei committed fd21f03 on branch LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3223-dialysate-flow-rate---dd---mode-7-17-2026 and 57 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> Wed, 15 Apr 2026 17:31:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-4 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> Wed, 15 Apr 2026 16:12:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3218-4

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

nope. removed.

fixed

fixed

fixed

fixed

· /firmware/App/Controllers/ROPump.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-3, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 14 Apr 2026 19:47:34 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> Tue, 14 Apr 2026 14:08:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line before return.

Add blank line after declarations.

Why U32? Why not RECOVER_STATE_T?

Lower case x

Is blood flow in need of a PID controller too?

· /firmware/App/Controllers/Valves.c	(-2, +33)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1215, +410)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-20, +15)	| History	| Source	| Diff

]]> Mon, 13 Apr 2026 14:58:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.