· /leahi_dialin/common/generic_defs.py	(-13, +361)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-0, +15)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-2, +4)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/balancing_chamber.py	(-7, +5)	| History	| Source	| Diff
· /leahi_dialin/td/treatment_delivery.py	(-0, +2)	| History	| Source	| Diff
· /leahi_dialin/utils/abstract_classes.py	(-0, +56)	| History	| Source	| Diff

]]> Tue, 21 Jul 2026 16:14:03 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=4bbcf07a714e5b38fb117023694cb0be0bd3815d https://devapps.diality.us/changelog/leahi-dialin?cs=4bbcf07a714e5b38fb117023694cb0be0bd3815d Zoltan Miskolci committed 4bbcf07 on branch LDT-5152-handler_refactor in leahi-dialin - fixed msg_id imports - updated td treatment

· /leahi_dialin/common/override_templates.py	(-5, +5)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/fp/filtration_purification.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/protocols/CAN.py	(-1, +3)	| History	| Source	| Diff
· /leahi_dialin/td/modules/treatment.py	(-125, +137)	| History	| Source	| Diff
· /leahi_dialin/td/proxies/ui_proxy.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/td/treatment_delivery.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/utils/abstract_classes.py	(-1, +1)	| History	| Source	| Diff

]]> Tue, 21 Jul 2026 12:46:10 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4410-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4410-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DIALIN-LDT-4410-1 ]]> Tue, 21 Jul 2026 10:50:09 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4410-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4410-1 Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-4410-1 LEAHI-DIALIN-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1: ]]> Tue, 21 Jul 2026 09:52:43 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 Vendor - TEL - Arpita Srivastava Closed LEAHI-DIALIN-LDT-3735-1 ]]> Tue, 21 Jul 2026 09:13:52 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=3f4937e339925dde0b95f08e49969f8983c5cba4 https://devapps.diality.us/changelog/leahi-dialin?cs=3f4937e339925dde0b95f08e49969f8983c5cba4 Zoltan Miskolci committed 3f4937e on branch LDT-5152-handler_refactor in leahi-dialin Refactor changes #1

· /leahi_dialin/common/msg_defs.py	(-152, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/alarms.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/balancing_chamber.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/concentrate_pump.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/dd_test_configs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/dialysate_pump.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/events.py	(-142, +109)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/heaters.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/mixing_cntrl.py	(-1, +1)	| History	| Source	| Diff
… 49 more files in changeset.

]]> Tue, 21 Jul 2026 07:29:20 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3735-1 LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Mon, 20 Jul 2026 16:56:17 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4410-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4410-1 Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4410-1 LEAHI-DIALIN-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1: ]]> Mon, 20 Jul 2026 16:46:46 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/leahi-dialin?cs=a68abf5742f400a8d97f4cf9ee4ce64edd64531c https://devapps.diality.us/changelog/leahi-dialin?cs=a68abf5742f400a8d97f4cf9ee4ce64edd64531c Vendor - TEL - Jashwant Gantyada committed a68abf5 on branch LDT-4410-dialysate-composition-mixing---, LDT-5152-handler_refactor and 3 more in leahi-dialin LDT-4410 restored comments

· /leahi_dialin/dd/modules/balancing_chamber.py

(-8, +8)

| History

| Source

| Diff

]]> Mon, 20 Jul 2026 12:34:32 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-5152-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-5152-1 Dara Navaei started review LEAHI-DIALIN-LDT-5152-1 ]]> Sun, 19 Jul 2026 08:27:47 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4614-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-4614-1 ]]> Wed, 15 Jul 2026 15:04:04 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4611-5 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4611-5 Dara Navaei started review LEAHI-DIALIN-LDT-4611-5 ]]> Mon, 13 Jul 2026 14:46:50 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 Tiffany Mejia and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3735-1 LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Mon, 13 Jul 2026 11:52:24 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=f65ed90f5f8af7672ae59bc5450d1a4f8935d041 https://devapps.diality.us/changelog/leahi-dialin?cs=f65ed90f5f8af7672ae59bc5450d1a4f8935d041 Zoltan Miskolci committed f65ed90 on branch LDT-3735-non-volatile-memory, LDT-5152-handler_refactor and 5 more in leahi-dialin removed debug messages

· /leahi_dialin/dd/modules/records.py

(-7, +0)

| History

| Source

| Diff

]]> Sun, 12 Jul 2026 23:43:02 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30436 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30436 Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

· /leahi_dialin/dd/modules/mixing_cntrl.py

(-0, +13)

| History

| Source

| Diff

]]> Wed, 01 Jul 2026 15:25:30 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=3e68e7de9179614903fffd17966447eb846963f0 https://devapps.diality.us/changelog/leahi-dialin?cs=3e68e7de9179614903fffd17966447eb846963f0 Zoltan Miskolci committed 3e68e7d on branch LDT-3735-non-volatile-memory, LDT-5152-handler_refactor and 5 more in leahi-dialin added reject reason handlers

· /leahi_dialin/dd/modules/records.py

(-6, +282)

| History

| Source

| Diff

]]> Wed, 01 Jul 2026 15:17:25 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4614-1 Dara Navaei started review LEAHI-DIALIN-LDT-4614-1 ]]> Wed, 01 Jul 2026 14:28:52 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30320 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30320 Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

• with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
• with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

• with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
• with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

fixed. thanks!

fixed. thanks