This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

We can update this function as part of another Jira ticket.

This one looks like maybe we could use the helper function. Have Vinay look at it.

I don't think so. The state is bit encoded, so special handling is required.

Updated

Fixed

This function also not using u32ArrayOverride()

is it possible to use the function u32ArrayOverride() here ?

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

I don't think mask or pos require initialization either.

I don't think valve needs to be initialized here. The for loop initializes it.