There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

This should return POST conductivity.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

Init PI Controls missing here.

13734.87F

· /firmware/App/Controllers/MixingControl.c

(-1, +1)

| History

| Source

| Diff

]]> Tue, 23 Jun 2026 11:04:43 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=32fffec9aca122c13f1d664b4c910bda2c8f1186 https://devapps.diality.us/changelog/dd-firmware?cs=32fffec9aca122c13f1d664b4c910bda2c8f1186 Vendor - TEL - Sameer Poyil committed 32fffec on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4612 modifying the acid type as 1K

· /firmware/App/Controllers/MixingControl.c

(-1, +1)

| History

| Source

| Diff

]]> Mon, 22 Jun 2026 15:58:25 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=575a1afb144e9a586f0860a1c8c9db6af940110e https://devapps.diality.us/changelog/dd-firmware?cs=575a1afb144e9a586f0860a1c8c9db6af940110e Vendor - TEL - Sameer Poyil committed 575a1af on branch develop in dd-firmware LDT-4612 mixing control updates

· /firmware/App/Controllers/MixingControl.c

(-1, +3)

| History

| Source

| Diff

]]> Mon, 22 Jun 2026 15:48:12 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=7ec4b7db95ed007bb1ea2565dde4d03c877f245a https://devapps.diality.us/changelog/dd-firmware?cs=7ec4b7db95ed007bb1ea2565dde4d03c877f245a Vendor - TEL - Sameer Poyil committed 7ec4b7d on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4612 mixing control splitting updates

· /firmware/App/Controllers/MixingControl.c

(-3, +3)

| History

| Source

| Diff

]]> Mon, 22 Jun 2026 13:27:47 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=a2180eecf9ed0c62849131ee19715c04d2dcbf22 https://devapps.diality.us/changelog/dd-firmware?cs=a2180eecf9ed0c62849131ee19715c04d2dcbf22 Vendor - TEL - Jashwant Gantyada committed a2180ee on branch develop in dd-firmware Merge branch 'LDT-4410-dialysate-composition-mixing-2' into develop

· /firmware/App/Controllers/MixingControl.c

(-8, +44)

| History

| Source

| Diff

]]> Mon, 22 Jun 2026 13:26:51 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=de5e503e4adc38658ac9d15cdad2b755a3ce566b https://devapps.diality.us/changelog/dd-firmware?cs=de5e503e4adc38658ac9d15cdad2b755a3ce566b Vendor - TEL - Jashwant Gantyada committed de5e503 on branch LDT-4410-dialysate-composition-mixing-2, develop in dd-firmware LDT-4410 addressed code review comments

· /firmware/App/Controllers/MixingControl.c	(-11, +15)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-15, +6)	| History	| Source	| Diff

]]> Mon, 22 Jun 2026 12:29:27 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1/#c30043 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1/#c30043 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4612-1

Can we move this exec at task level, independent of Drybicart operations?

Comment missing?

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

both acid and bicarb mix volume

Add MULTIPLIER at the end.

Initialize at init function.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Lets remove this.

· /firmware/App/Controllers/MixingControl.c	(-2, +34)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-2, +3)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-4, +76)	| History	| Source	| Diff

]]> Sun, 21 Jun 2026 21:16:56 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-4409-2 ]]> Thu, 18 Jun 2026 12:59:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=7c29e738c37a25cc72d68686d852e087f2f1577d https://devapps.diality.us/changelog/dd-firmware?cs=7c29e738c37a25cc72d68686d852e087f2f1577d Vendor - TEL - Sameer Poyil committed 7c29e73 on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4612 fix for mixing control

· /firmware/App/Controllers/MixingControl.c	(-2, +10)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 10:06:02 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=b6411a65e0c78fe8b296c047a1d6940c55fa64f5 https://devapps.diality.us/changelog/dd-firmware?cs=b6411a65e0c78fe8b296c047a1d6940c55fa64f5 Vendor - TEL - Sameer Poyil committed b6411a6 on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4409 fix for concentrate pump not running

· /firmware/App/Controllers/DryBiCart.c	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-1, +1)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +1)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 04:02:22 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4612-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4612-1 ]]> Wed, 17 Jun 2026 22:13:02 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=a08bda2a0610a27e3147fed72e1aca7b798a1bb0 https://devapps.diality.us/changelog/dd-firmware?cs=a08bda2a0610a27e3147fed72e1aca7b798a1bb0 Vendor - TEL - Sameer Poyil committed a08bda2 on branch LDT-4612-dialysate-composition-integ, develop in dd-firmware LDT-4612 fix for micing control integration issues

· /firmware/App/Controllers/DryBiCart.c	(-21, +18)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-3, +7)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:37:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=145fd716a856f864f39fb0f9884865f6e45b9256 https://devapps.diality.us/changelog/dd-firmware?cs=145fd716a856f864f39fb0f9884865f6e45b9256 Dara Navaei committed 145fd71 on branch LDT-3975-water-treatment-and-degassing--, LDT-4410-dialysate-composition-mixing-2 and 3 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:24:08 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Jashwant Gantyada and Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-4409-2 LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1: ]]> Tue, 16 Jun 2026 13:23:38 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=cabab4c56b6840c94126b71696d2c95011cb01a0 https://devapps.diality.us/changelog/dd-firmware?cs=cabab4c56b6840c94126b71696d2c95011cb01a0 Vendor - TEL - Sameer Poyil committed cabab4c on branch LDT-3975-water-treatment-and-degassing--, LDT-4409-dialysate-composition-beta-2.1-WCID-implementation and 4 more in dd-firmware LDT-4409 addressed review comments

· /firmware/App/Controllers/DryBiCart.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +5)	| History	| Source	| Diff

]]>