yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

removed

Remove this extra line

reverted handler to the original version. This was required to get a merge with develop to work

fixed.

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

Duplicate, please remove

merged staging into dry bicart branch and code is pushed

New code pushed

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

This is not the code that is currently on staging, so I think you need to update it from there

fixed it

This is a change from Zoltan and I am updated that into my local branch

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

Add a blank line between functions.

Is this staying? Is all of above replacing this class?