Fisheye on leahi-dialin/leahi_dialin/fp/modules https://devapps.diality.us/changelog/~br%3Ddevelop/leahi-dialin/leahi_dialin/fp/modules Recent activity in "leahi-dialin" under directory /leahi_dialin/fp/modules LEAHI-DIALIN-LDT-696-1: closed by Zoltan Miskolci Mon, 30 Mar 2026 14:33:37 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-696-1 ]]> LEAHI-DIALIN-LDT-696-1: reviewers finished Mon, 30 Mar 2026 11:30:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> LEAHI-DIALIN-LDT-2655-1: reviewers finished Mon, 30 Mar 2026 09:39:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-3218-1: started by Dara Navaei Thu, 26 Mar 2026 12:16:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 Dara Navaei started review LEAHI-DIALIN-LDT-3218-1 ]]> LEAHI-DIALIN-LDT-696-1: reviewers finished Thu, 26 Mar 2026 11:16:40 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> LEAHI-DIALIN-LDT-696-1: comment by Zoltan Miskolci "Added" Thu, 26 Mar 2026 10:30:02 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

Added

]]> LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "Add a TODO comment to change the message once i..." Thu, 26 Mar 2026 06:32:24 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28136 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28136 Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

Add a TODO comment to change the message once implemented in FW

]]> LEAHI-DIALIN-LDT-3629-2: closed by Zoltan Miskolci Mon, 23 Mar 2026 09:13:46 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-2 ]]> LEAHI-DIALIN-LDT-696-1: comment by Zoltan Miskolci "removed duplicate" Fri, 20 Mar 2026 14:07:24 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28128 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28128 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

removed duplicate

]]> LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "ROPump is repeated" Fri, 20 Mar 2026 14:04:11 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28127 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28127 Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

ROPump is repeated

]]> LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "RECOVERY_STATES" Fri, 20 Mar 2026 13:56:10 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28126 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28126 Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

RECOVERY_STATES

]]> LEAHI-DIALIN-LDT-696-1: started by Dara Navaei Fri, 20 Mar 2026 13:46:22 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Dara Navaei started review LEAHI-DIALIN-LDT-696-1 ]]> LEAHI-DIALIN-LDT-3629-2: reviewers finished Wed, 18 Mar 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-2 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> LEAHI-DIALIN-LDT-3629-2: comment by Raghu Kallala "update params" Tue, 17 Mar 2026 07:05:16 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-2

update params

]]> LEAHI-DIALIN-LDT-3629-2: started by Dara Navaei Mon, 16 Mar 2026 12:06:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Dara Navaei started review LEAHI-DIALIN-LDT-3629-2 ]]> LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..." Mon, 16 Mar 2026 10:04:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

]]> LEAHI-DIALIN-LDT-3629-1: closed by Zoltan Miskolci Thu, 12 Mar 2026 14:32:23 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-1 ]]> LEAHI-DIALIN-LDT-3629-1: reviewers finished Thu, 12 Mar 2026 14:12:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-1 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "Fixed" Thu, 12 Mar 2026 11:50:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

Fixed

]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "added Todo comment" Thu, 12 Mar 2026 11:48:59 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27938 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27938 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

added Todo comment

]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "They were added while debugging fp_test_configs..." Thu, 12 Mar 2026 11:47:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27937 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27937 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

]]> LEAHI-DIALIN-LDT-3629-1: comment by Michael Garthwaite "tip: use the logger and set the statement to er..." Thu, 12 Mar 2026 10:59:15 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27936 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27936 Michael Garthwaite replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

tip: use the logger and set the statement to error level and you can see it in runtime

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "pressure limit will be unsigned int not signed ..." Thu, 12 Mar 2026 09:49:11 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27913 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27913 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "Are these print statements add for debugging? ..." Thu, 12 Mar 2026 09:45:48 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27912 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27912 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

Are these print statements add for debugging?
If not, is this allowed

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "typo, PUMP_ON_STATE" Thu, 12 Mar 2026 09:36:55 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27910 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27910 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

typo, PUMP_ON_STATE

]]> LEAHI-DIALIN-LDT-3629-1: started by Dara Navaei Tue, 10 Mar 2026 11:48:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Dara Navaei started review LEAHI-DIALIN-LDT-3629-1 ]]> LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci Thu, 05 Mar 2026 10:46:36 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1 ]]> LEAHI-DIALIN-LDT-3557-1: reviewers finished Thu, 05 Mar 2026 10:25:20 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1 LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables ]]> LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity... Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei joined LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity... Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]>