Fisheye on leahi-dialin/tests/depreciated_tests

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..."

Michael Garthwaite — Mon, 16 Mar 2026 10:04:25 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei joined LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 22 Jan 2026 10:07:41 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Wed, 21 Jan 2026 12:35:59 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u...

Wed, 21 Jan 2026 09:47:38 -0800

Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Tue, 20 Jan 2026 15:33:25 -0800

Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: comment by Zoltan Miskolci "Putting the aliases at the end makes them group..."

Zoltan Miskolci — Mon, 12 Jan 2026 17:07:56 -0800

Zoltan Miskolci replied to Sean Nash in LEAHI-DIALIN-LDT-3214-1

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

LEAHI-DIALIN-LDT-3214-1: comment by Sean Nash "Why move this here? Seems like an odd placemen..."

Sean Nash — Mon, 12 Jan 2026 13:04:02 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-3214-1

Why move this here? Seems like an odd placement so far away from D14.

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Removed some empty lines to have the same formating throgh the files

Zoltan Miskolci — Fri, 09 Jan 2026 11:41:12 -0800

Zoltan Miskolci committed 18c90a1 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 35 more in leahi-dialin

- Removed some empty lines to have the same formating throgh the files

· /leahi_dialin/common/fp_defs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/override_templates.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-9, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-5, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-8, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-4, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-7, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-6, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-3, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

… 39 more files in changeset.

LEAHI-DIALIN-LDT-3214-1: started by Dara Navaei

Dara Navaei — Tue, 06 Jan 2026 16:33:01 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:33:43 -0800

Dara Navaei Needs Fixing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:33:39 -0800

Dara Navaei Abandoned LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-2655-1: comment by Sean Nash "Why do we have an "ro" and an "fp" folder? Is ..."

Sean Nash — Tue, 09 Dec 2025 14:26:46 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-2655-1

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

LEAHI-DIALIN-LDT-2655-1: started by Dara Navaei

Dara Navaei — Mon, 08 Dec 2025 08:15:35 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-566-2: closed by Michael Garthwaite

Michael Garthwaite — Tue, 05 Aug 2025 13:05:01 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LDT-566-2

LEAHI-DIALIN-LDT-566-2: reviewers finished

Tue, 05 Aug 2025 12:50:55 -0700

Sean Nash and Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-566-2

LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2

LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "Why so much white space?"

Sean Nash — Fri, 01 Aug 2025 15:47:05 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-566-2

Why so much white space?

LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "???"

Sean Nash — Fri, 01 Aug 2025 15:44:23 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-566-2

???

LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "Where is 0x5B?"

Sean Nash — Fri, 01 Aug 2025 15:40:11 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-566-2

Where is 0x5B?

leahi-dialin (LDT-2655-fix_conductivity_override): Merge branch 'LDT-566-water-treatment-and-degassing-fp-2' into develop

Michael Garthwaite — Tue, 15 Jul 2025 13:12:13 -0700

Michael Garthwaite committed fe37f0a on branch LDT-2655-fix_conductivity_override, develop in leahi-dialin

Merge branch 'LDT-566-water-treatment-and-degassing-fp-2' into develop

· /leahi_dialin/dd/modules/piston_pump.py	(-0, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/levels.py	(-5, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/valves.py	(-4, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-54, +9)	\| History	\| Source	\| Diff
· /tests/depreciated_tests/test_uf.py	(-0, +94)	\| History	\| Source

leahi-dialin (feature/LDT-783-stop-state): LDT-556: created boost pump and ro pump modules. Updated naming to across modules from RO to FP. Moved older denali test...

Michael Garthwaite — Tue, 15 Jul 2025 13:11:53 -0700

Michael Garthwaite committed 68422d0 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1195-dd-request-for-a-variable-for-b and 75 more in leahi-dialin

LDT-556: created boost pump and ro pump modules. Updated naming to across modules from RO to FP. Moved older denali tests to a depreciated tests. Created a thread-based diagnostic logger for fp

· /leahi_dialin/common/msg_ids.py

(-49, +62)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/piston_pump.py

(-0, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/proxies/ro_proxy.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/fp/filtration_purification.py

(-7, +13)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +242)

| History

| Source

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-6, +6)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/flow_sensors.py

(-4, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/levels.py

(-5, +5)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/pressure_sensors.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/ro_pump.py

(-0, +242)

| History

| Source

· /leahi_dialin/fp/modules/temperatures.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/valves.py

(-4, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/water_pumps.py

(-54, +9)

| History

| Source

| Diff

· /leahi_dialin/fp/proxies/__init__.py

(-0, +0)

| History

| Source

· /leahi_dialin/fp/proxies/dd_proxy.py

(-0, +62)

| History

| Source

… 76 more files in changeset.

LEAHI-DIALIN-LDT-566-2: started by Dara Navaei

Dara Navaei — Mon, 23 Jun 2025 17:48:15 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-566-2