leahi-common

Clone Tools

Stats

Commits this week: 12
Total Committers: 11
Last Commit: 26 Nov
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Dec
6:44 pm

Vendor - TEL - Sameer Poyil

use the Rinse pump API to get the flow rate

use the Rinse pump API to get the flow rate

6:43 pm

Vendor - TEL - Sameer Poyil

implement an API in RinsePump and call that API.

implement an API in RinsePump and call that API.

11:23 am

Sean Nash

No need to initialize these to zero.

No need to initialize these to zero.

11:22 am

Raghu Kallala

Something like this ( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

Something like this
( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

11:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:56 am

Vendor - TEL - Sameer Poyil

added

added

8:56 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:56 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:56 am

Vendor - TEL - Sameer Poyil

added

added

8:56 am

Vendor - TEL - Sameer Poyil

removed

removed

8:55 am

Vendor - TEL - Sameer Poyil

added comments

added comments

8:55 am

Vendor - TEL - Sameer Poyil

removed

removed

8:54 am

Vendor - TEL - Sameer Poyil

added

added

8:54 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:54 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:53 am

Vendor - TEL - Sameer Poyil

updated

updated

8:51 am

Vendor - TEL - Sameer Poyil

removed

removed

8:51 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:50 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:50 am

Vendor - TEL - Sameer Poyil

fixed it.

fixed it.

Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

11:32 am

Sean Nash

Add space before ).

Add space before ).

11:32 am

Sean Nash

Add space between if and (.

Add space between if and (.

11:31 am

Sean Nash

Be consistent on whether you have a blank line between break and next case.

Be consistent on whether you have a blank line between break and next case.

11:30 am

Sean Nash

Keep blank line here.

Keep blank line here.

11:12 am

Sean Nash

What are these coefficients for? At least describe in comments, if not the names.

What are these coefficients for? At least describe in comments, if not the names.