application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 01 Feb 21
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Feb 2021
5:44 pm

Behrouz NematiPour

DEN-5759: Code Review 0

- Added a TODO for the DoubleSlider component to add a validation and active feature to be able to use it for PreTreatmentCreate.

Options
    • -6
    • +10
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
2:26 pm

Behrouz NematiPour

DEN-5759: prTx: Code Review 0

Options
    • -1
    • +0
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
Wednesday 27 Jan 2021
5:16 pm

Behrouz NematiPour

DEN-5758: Code Analysis

Options
    • -96
    • +106
    /cppcheck.log
Sunday 24 Jan 2021
9:13 pm

Behrouz NematiPour

DEN-6612 UI_DVT: Pre-Treatment Ultrafiltration

- This story wasn't part of the current sprint S37 but while I worked on it to be able to push it to master ASAP, so put the story as the commit comment.

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +2
    /sources/view/VTreatmentBegin.h
    • -2
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +14
    /unittests/tst_messaging.cpp
    • -0
    • +1
    /unittests/tst_messaging.h
    • -0
    • +46
    /unittests/tst_models.cpp
    • -0
    • +3
    /unittests/tst_models.h
Thursday 21 Jan 2021
7:13 pm

Behrouz NematiPour

DEN-5757: Code Coverage

Options
    • -0
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
7:10 pm

Behrouz NematiPour

Merge branch 'master' into DEN-5751_Pre-TreatmentUltrafiltration

Options
    • -4
    • +8
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +8
    /denali.qrc
    • -3
    • +17
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +2
    /sources/canbus/MessageDispatcher.h
    • -2
    • +4
    /sources/canbus/MessageGlobals.h
    • -42
    • +47
    /sources/canbus/MessageInterpreter.cpp
    • -20
    • +26
    /sources/gui/GuiGlobals.h
    • -12
    • +55
    /sources/gui/qml/globals/Colors.qml
    • -8
    • +9
    /sources/gui/qml/globals/Variables.qml
    • -108
    • +110
    /sources/gui/qml/main.qml
    • -20
    • +50
    /sources/model/MModel.h
    • -14
    • +44
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
5:21 pm

Behrouz NematiPour

Server coverage issue fixed

- This line was not covered on server although it was covered on local.

Tested locally and it is working.

Options
    • -1
    • +3
    /sources/view/hd/alarm/VAlarmStatus.cpp
1:11 pm

Behrouz NematiPour

Build failed on server because the fw common branch master was changed.

- commented out the removed enum from application.

Options
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -4
    • +4
    /sources/view/hd/data/VHDTreatmentStatesData.cpp
Wednesday 20 Jan 2021
8:03 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign'

Options
Tuesday 19 Jan 2021
11:38 am

Behrouz NematiPour

DEN-5753: Update Design Documents

- Fixed comments in some files of the Pre-Treatment Create.

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentConfirm.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentPrime.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
Tuesday 12 Jan 2021
6:31 pm

Behrouz NematiPour

DEN-5754: Implementation

- Removed not used SliderDoubleCreateTreatment.qml component.

Options
    • -1
    • +0
    /denali.qrc
    • -194
    • +0
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
5:56 pm

Behrouz NematiPour

DEN-5838: Code Review 0

Options
    • -1
    • +2
    /cr_objectives.sh
    • -1
    • +0
    /sources/model/hd/alarm/MAlarmStatusData.cpp
5:44 pm

Behrouz NematiPour

DEN-5754: Implementation

- code refactoring and clean up

Options
    • -1
    • +1
    /denali.pro.user
    • -5
    • +8
    /denali.qrc
    • -0
    • +55
    /sources/gui/qml/components/TitleBarCreateTreatment.qml
    • -55
    • +0
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -0
    • +55
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentBase.qml
    • -0
    • +88
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentConfirm.qml
    • -0
    • +660
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +124
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentPrime.qml
    • -0
    • +123
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
    • -144
    • +0
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -108
    • +0
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -670
    • +0
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -140
    • +0
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -11
    • +12
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
Monday 11 Jan 2021
10:37 pm

Behrouz NematiPour

DEN-5754: Implementation

- Code clean up

Options
    • -5
    • +5
    /denali.pro.user
    • -1
    • +2
    /denali.qrc
    • -71
    • +0
    /sources/gui/qml/components/CircleWithText.qml
    • -35
    • +23
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
    • -2
    • +1
    /sources/gui/qml/components/GridSelection.qml
    • -0
    • +66
    /sources/gui/qml/components/StepBullet.qml
    • -0
    • +86
    /sources/gui/qml/components/StepIndicator.qml
    • -147
    • +22
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -1
    • +1
    /sources/gui/qml/globals/Colors.qml
    • -0
    • +5
    /sources/gui/qml/globals/Variables.qml
    • -5
    • +5
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -10
    • +10
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -8
    • +9
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -9
    • +9
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -10
    • +10
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
Friday 08 Jan 2021
6:51 pm

Behrouz NematiPour

DEN-5837: Code Analysis

Options
    • -5
    • +7
    /cppcheck.err
    • -94
    • +104
    /cppcheck.log
    • -0
    • +3
    /cr_objectives.sh
    • -1
    • +1
    /denali.pro.user
3:37 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 100.000% (4827/4827)

- added a unit test for the AlarmGenerator private method setBits.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -3
    • +9
    /sources/AlarmGenerator.h
    • -0
    • +17
    /unittests/tst_messaging.cpp
    • -0
    • +2
    /unittests/tst_messaging.h
1:35 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 99.979% (4826/4827)

Options
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -40
    • +41
    /sources/canbus/MessageInterpreter.cpp
    • -5
    • +16
    /sources/model/MModel.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
Thursday 07 Jan 2021
5:13 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- commented as manually tested the AlarmClearedCondition.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +2
    /sources/AlarmGenerator.cpp
    • -1
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -3
    • +3
    /sources/gui/GuiController.cpp
    • -1
    • +0
    /sources/gui/qml/components/TimeText.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
Tuesday 05 Jan 2021
5:20 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- 99.110% (4790/4833)

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -0
    • +2
    /sources/model/hd/alarm/MAlarmClearedCondition.cpp
    • -1
    • +2
    /sources/model/hd/alarm/MAlarmClearedCondition.h
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
Monday 04 Jan 2021
2:43 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- updated the alarm message table

- fixed the -q parameter

Options
    • -1
    • +1
    /denali.pro.user
    • -59
    • +111
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -9
    • +8
    /sources/view/hd/alarm/VAlarmStatus.cpp
Tuesday 22 Dec 2020
9:28 am

Behrouz NematiPour

DEN-5833: Implementation

- Added a UI "AlarmGenerator" class to handle the HD_COMM_TIMEOUT and later the BLE Cuff alarm (PRS 395).

Options
    • -0
    • +2
    /denali.pro
    • -0
    • +75
    /sources/AlarmGenerator.cpp
    • -0
    • +55
    /sources/AlarmGenerator.h
    • -6
    • +2
    /sources/gui/GuiController.cpp
    • -8
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
Thursday 17 Dec 2020
4:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- Cleaned up the unit tests

Options
    • -25
    • +3
    /unittests/tst_canbus.cpp
    • -1
    • +0
    /unittests/tst_canbus.h
    • -225
    • +0
    /unittests/tst_messaging.cpp
    • -16
    • +0
    /unittests/tst_messaging.h
    • -1
    • +1
    /unittests/tst_models.cpp
1:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- added a touch expanding area for the TouchArea so regardless of its visual size it can have expanded touchable area.

- the touch expanding for the mute button set to 25 so it can have a bigger touch area that its size which is little.

Options
    • -1
    • +1
    /sources/gui/qml/components/MuteButton.qml
    • -0
    • +1
    /sources/gui/qml/components/NotificationBar.qml
    • -1
    • +4
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
Wednesday 16 Dec 2020
3:07 pm

Behrouz NematiPour

DEN-5754: Implementation

- cherry picked a fix from DEN-5830_AlarmDesign@51accb for the Treatment End message which has no payload.

- Also made the interpretMessage() for received messages to be more identical to the DEN-5830_AlarmDesign to hopefully help merging easier.

Options
    • -7
    • +20
    /sources/canbus/MessageInterpreter.cpp
2:55 pm

Behrouz NematiPour

DEN-6022: The ultrafiltration inconsistency

- Had a conversation with Syseng(Nic) and Fweng(Sean) and decided to have the fix somehow more understandable but there is no actual fix and if that happens it would be the FW bug.

- The modification is that the main progress bar will always has VTreatmentUltratiltration.minimum as minimum (current;y always zero) and VTreatmentUltratiltration.maximum as maximum.

- The UI always expects to get the vTreatmentRanges.treatmentRanges_Ultrafiltration_Volume_Min (adjustable min and slider min) greater than vTreatmentUltrafiltration.ultrafiltration_RefUFVol (current uf volume delivered and current value on the progress bar) and so close to eachother.

- Removed the precision from VTreatmentUltrafiltration and moved into the Variables.

Options
    • -4
    • +6
    /sources/gui/qml/globals/Variables.qml
    • -2
    • +2
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml
    • -27
    • +17
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml
    • -2
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml
    • -2
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationStart.qml
    • -2
    • +1
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
    • -6
    • +2
    /sources/view/hd/data/VTreatmentUltrafiltration.h
Tuesday 15 Dec 2020
9:45 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added a MACRO for convenience of empty payload messages handling.

Options
    • -1
    • +9
    /sources/canbus/MessageInterpreter.cpp
9:12 pm

Behrouz NematiPour

DEN-5833: Implementation

- Fixed the bug that alarm ID zero which is the clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed notification signal not to raise and GUI wasn't getting updated.

Options
    • -6
    • +6
    /sources/view/hd/alarm/VAlarmStatus.cpp
6:33 pm

Behrouz NematiPour

DEN-5754: Implementation

- Fixed a bug caused by a typo

Options
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
Monday 14 Dec 2020
7:02 pm

Behrouz NematiPour

DEN-5754: Implementation

- linked the pre-treatment ultrafiltration adjustment with the in-treatment ultrafiltration section and the adjustment flow.

- added the rejection reason text to the pTx uf adj screen.

Options
    • -1
    • +1
    /sources/gui/qml/components/NotificationBar.qml
    • -1
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -10
    • +14
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -2
    • +17
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
1:43 pm

Behrouz NematiPour

DEN-5754: Implementation

- Fixed the message id of the ID_ConfirmTreatmentReq from 58 to 59

- Enabled the priming button for now since there is no FW implementation.

Options
    • -1
    • +1
    /sources/gui/GuiGlobals.h
    • -1
    • +2
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml