dd-firmware / firmware / App / Controllers

Valves.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 7
Last Commit: 09 Oct
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Dec
2:27 pm

Sean Nash

This function has an output.

This function has an output.

2:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

Friday 12 Dec
11:11 am

Sean Nash

Remove blank line.

Remove blank line.

11:11 am

Sean Nash

11:05 am

Sean Nash

Should we add _TARGET to these names for clarity?

Should we add _TARGET to these names for clarity?

11:03 am

Sean Nash

Is the count really a float?

Is the count really a float?

11:02 am

Sean Nash

Do we need an override for the RPM feedback?

Do we need an override for the RPM feedback?

11:00 am

Sean Nash

This is a maximum per treatment?

This is a maximum per treatment?

9:39 am

Sean Nash

I'm not seeing fixes in this file.

I'm not seeing fixes in this file.

9:37 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:23 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:21 am

Michael Garthwaite

moved the sets into a separate function from init

moved the sets into a separate function from init

9:15 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:15 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

Tuesday 09 Dec
10:27 am

Sean Nash

Shouldn't EVERY state set ALL valves?

Shouldn't EVERY state set ALL valves?

Monday 08 Dec
7:02 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

7:00 pm

Vendor - TEL - Sameer Poyil

Let public function on top

Let public function on top

6:53 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

6:52 pm

Vendor - TEL - Sameer Poyil

Mixing static and public function , let public function comes on top

Mixing static and public function , let public function comes on top

6:50 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

2:52 pm

Vinayakam Mani

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

2:50 pm

Vinayakam Mani

Done.

Done.

2:48 pm

Vinayakam Mani

Done.

Done.