td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 51
Total Committers: 13
Last Commit: 16:15
Commits this week: 51

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

6 hrs ago

Sean Nash

Still need to range check the rate, reject if out of range, accept and assign if in range.

Still need to range check the rate, reject if out of range, accept and assign if in range.

6 hrs ago

Sean Nash

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

6 hrs ago

Sean Nash

6 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT1394 commented h4 reset function

Options
    • -18
    • +18
    ./Controllers/BloodFlow.c
    • -1
    • +1
    ./Controllers/BloodFlow.h
7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Assigned to local variable

Assigned to local variable

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated to else part

Updated to else part

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

8 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

8 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-1394 addressed code review comments

Options
    • -2
    • +2
    ./Drivers/PeristalticPump.c
8 hrs ago

Sean Nash

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

9 hrs ago

Vendor - TEL - Jashwant Gantyada

handled accordingly.

handled accordingly.

9 hrs ago

Vendor - TEL - Jashwant Gantyada

removed and added.

removed and added.

9 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-1394 addressed code review comments

Options
    • -4
    • +4
    ./Controllers/BloodFlow.c
    • -2
    • +28
    ./Drivers/PeristalticPump.c
    • -0
    • +1
    ./Drivers/PeristalticPump.h
    • -2
    • +2
    ./Services/FpgaTD.c
10 hrs ago

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

10 hrs ago

Vendor - TEL - Sameer Poyil

implemented

implemented

10 hrs ago

Vendor - TEL - Sameer Poyil

fixed

fixed

11 hrs ago

Sean Nash

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

12 hrs ago

Sean Nash

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

12 hrs ago

Sean Nash

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we a...

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we assign new rate to your static variable.

12 hrs ago

Sean Nash

I think this can just be an else since resume is the only remaining possibility.

I think this can just be an else since resume is the only remaining possibility.

12 hrs ago

Sean Nash

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

12 hrs ago

Sean Nash

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

12 hrs ago

Sean Nash

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

12 hrs ago

Sean Nash

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

12 hrs ago

Sean Nash

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

13 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-1394 added h4 rotor revs count for broadcasting it

Options
    • -4
    • +5
    ./Controllers/BloodFlow.c
    • -0
    • +13
    ./Services/FpgaTD.c
    • -0
    • +1
    ./Services/FpgaTD.h
13 hrs ago

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation