td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 51
Total Committers: 13
Last Commit: 02 Mar
Commits this week: 51

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Mar
8:46 pm

Sean Nash

4:41 pm

Sean Nash

Still need to range check the rate, reject if out of range, accept and assign if in range.

Still need to range check the rate, reject if out of range, accept and assign if in range.

4:26 pm

Sean Nash

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

4:16 pm

Sean Nash

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Assigned to local variable

Assigned to local variable

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Updated to else part

Updated to else part

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

2:51 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:13 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:58 pm

Sean Nash

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

1:32 pm

Vendor - TEL - Jashwant Gantyada

handled accordingly.

handled accordingly.

1:32 pm

Vendor - TEL - Jashwant Gantyada

removed and added.

removed and added.

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

11:16 am

Sean Nash

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

10:42 am

Sean Nash

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

10:18 am

Sean Nash

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we a...

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we assign new rate to your static variable.

10:15 am

Sean Nash

I think this can just be an else since resume is the only remaining possibility.

I think this can just be an else since resume is the only remaining possibility.

10:10 am

Sean Nash

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

9:59 am

Sean Nash

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

9:56 am

Sean Nash

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

9:53 am

Sean Nash

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

9:51 am

Sean Nash

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

9:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
7:42 am

Vendor - TEL - Sameer Poyil

Fixed

Fixed

7:37 am

Vendor - TEL - Sameer Poyil

removed from here

removed from here

7:36 am

Vendor - TEL - Sameer Poyil

fixed

fixed

Friday 27 Feb
2:56 pm

Vendor - TEL - Sameer Poyil

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?