dd-firmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 4
Last Commit: 11 Feb
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 16 Apr
8:15 am

Michael Garthwaite

Wednesday 15 Apr
5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

Tuesday 14 Apr
2:08 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:07 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:05 pm

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

2:04 pm

Sean Nash

Lower case x

Lower case x

2:02 pm

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

Wednesday 25 Mar
11:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Friday 23 Jan
1:07 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ROPump.c
1:03 pm

Michael Garthwaite

1:02 pm

Sean Nash and Raghu Kallala

12:55 pm

Michael Garthwaite

LDT-2977: code review adjust

Options
    • -2
    • +0
    ./ROPump.c
12:51 pm

Michael Garthwaite

fixed.

fixed.

12:51 pm

Michael Garthwaite

LDT-2977: code review comments.

Options
    • -0
    • +5
    ./ROPump.c
12:49 pm

Michael Garthwaite

LDT-2977: code review comments.

Options
    • -2
    • +2
    ./ROPump.c
12:48 pm

Sean Nash

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

12:09 pm

Michael Garthwaite

fixed for both _TO_PWM macros

fixed for both _TO_PWM macros

12:09 pm

Michael Garthwaite

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

12:08 pm

Michael Garthwaite

LDT-2977: code review updates. Removed macro for flow that used counts

Options
    • -6
    • +4
    ./ROPump.c
12:06 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2977-iofp-update

Options
    • -19
    • +51
    ./ROPump.c
9:52 am

Sean Nash

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.