Monitors

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733 Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

Did you get a chance to test this alarm and uncomment the code?

Did you get a chance to test this alarm and uncomment the code?

Remove empty space.

Remove empty space.

ACToDC?

ACToDC?

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Align comment. Clarify (at least in comments) that these macros are for FPGA count conversions.

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

Remove extra blank lines.

Remove extra blank lines.

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

please align this comments with below structure

please align this comments with below structure

Please align the comments

Please align the comments

could you please align it ?

could you please align it ?

Add blank line (should be 2 before test support banner).

Add blank line (should be 2 before test support banner).

Remove blank line.

Remove blank line.

Needs doxygen comments.

Needs doxygen comments.

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

Reverted change. Added uncompensated conductivity to the conductivity publishing

Reverted change. Added uncompensated conductivity to the conductivity publishing

space after if.

space after if.

Space after if.

Space after if.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.