firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
change accordingly

change accordingly

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Do we still need this?

Do we still need this?

test instead of handle

test instead of handle

Align =

Align =

Should modality be an enum type?

Should modality be an enum type?

Align =

Align =

Should this be an enum type?

Should this be an enum type?

Yes, Fixed

Yes, Fixed

For testing purpose, Since UI board had old build so it was throwing the alarms

For testing purpose, Since UI board had old build so it was throwing the alarms

I see in the commits that you commented this #define was that on purpose?

I see in the commits that you commented this #define was that on purpose?

Per our coding standards, it should be "0 == currentAirPumpRPM".

Per our coding standards, it should be "0 == currentAirPumpRPM".

What is the 3rd modality?

What is the 3rd modality?

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Move after Modes so they are alphabetized.

Move after Modes so they are alphabetized.

Remove extra ;

Remove extra ;