td-firmware / firmware / App / Controllers

AirTrap.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 13 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 26 Apr
2:48 pm

Sean Nash

Is this permanent? If so, just delete commented code. If not, add a TODO comment to remind us to come back to this later.

Is this permanent? If so, just delete commented code. If not, add a TODO comment to remind us to come back to this later.

Wednesday 25 Mar
6:46 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Monday 23 Mar
5:37 pm

Vendor - TEL - Sameer Poyil

10:30 am

Sean Nash

Tuesday 17 Mar
11:05 pm

Vendor - TEL - Sameer Poyil

reverted back

reverted back

11:05 pm

Vendor - TEL - Sameer Poyil

This code is removed and not required

This code is removed and not required

Friday 13 Mar
3:21 pm

Vendor - TEL - Praneeth Bunne

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

2:23 pm

Sean Nash

1:45 pm

Vinayakam Mani

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

Wednesday 11 Mar
5:40 pm

Sean Nash

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

5:30 pm

Sean Nash

Add space between if and (

Add space between if and (

4:55 pm

Vendor - TEL - Sameer Poyil

Fixed

Fixed

3:31 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
Tuesday 10 Mar
1:58 pm

Sean Nash

Comment to right no longer makes sense.

Comment to right no longer makes sense.

Friday 06 Mar
2:27 pm

Sean Nash

Should this event be TD_EVENT_AIR_TRAP_FILL?

Should this event be TD_EVENT_AIR_TRAP_FILL?

Wednesday 04 Mar
8:22 pm

Vendor - TEL - Sameer Poyil

4:01 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Monday 02 Mar
9:01 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AirTrap.c
  2. … 8 more files in changeset.
8:46 pm

Sean Nash

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

11:45 am

Vendor - TEL - Sameer Poyil

LDT-1903 Air Trap Addressed code review comments

Options
    • -10
    • +1
    ./AirTrap.c
11:41 am

Vendor - TEL - Sameer Poyil

LDT-1903 Air Trap adding duty cycle out of range software fault alarm

Options
    • -2
    • +5
    ./AirTrap.c
  2. … 2 more files in changeset.
9:53 am

Sean Nash

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

9:51 am

Sean Nash

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

7:42 am

Vendor - TEL - Sameer Poyil

Fixed

Fixed

7:40 am

Vendor - TEL - Sameer Poyil

LDT-1903 Air Trap updates

Options
    • -2
    • +1
    ./AirTrap.c
7:37 am

Vendor - TEL - Sameer Poyil

removed from here

removed from here