td-firmware / firmware / App / Controllers

AirTrap.c

Clone Tools

Stats

Commits this week: 7
Total Committers: 2
Last Commit: 13:47
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Dara Navaei

Done.

Done.

1 hr ago

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

1 hr ago

Dara Navaei

I have to make sure the valve is correct before using it.

I have to make sure the valve is correct before using it.

1 hr ago

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2 hrs ago

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2 hrs ago

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2 hrs ago

Sean Nash

Is this temporary?

Is this temporary?

3 hrs ago

Dara Navaei

Done

Done

Monday 15 Dec
2:23 pm

Sean Nash

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Sunday 14 Dec
7:26 pm

Dara Navaei

Done

Done

Thursday 11 Dec
10:48 am

Dara Navaei

LDT-1886 changed the air trap raise and lower level maximum override levels

Options
    • -3
    • +3
    ./AirTrap.c
10:15 am

Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

10:14 am

Vendor - TEL - Sameer Poyil

let public function on top

let public function on top

10:11 am

Vendor - TEL - Sameer Poyil

Let all public functions come on top for all files

Let all public functions come on top for all files

Wednesday 10 Dec
9:53 am

Dara Navaei

LDT-2931 changed the overrides for the lower and raise air trap levels to accept up to 100% PWM

Options
    • -2
    • +3
    ./AirTrap.c
Friday 05 Dec
2:55 pm

Sean Nash

Should we comment this out before merging?

Should we comment this out before merging?

2:11 pm

Sean Nash

Tuesday 02 Dec
9:50 am

Dara Navaei

Done

Done

9:49 am

Dara Navaei

Done

Done

9:16 am

Sean Nash

Align =

Align =

9:14 am

Sean Nash

Should be 2 blank lines above/below test banner.

Should be 2 blank lines above/below test banner.

Monday 01 Dec
9:43 am

Dara Navaei

Done

Done

9:11 am

Sean Nash

Should we initialize to inactive (and use #define)?

Should we initialize to inactive (and use #define)?

Tuesday 25 Nov
4:01 pm

Dara Navaei

Took note that the FPGA interface is at the driver level.

Took note that the FPGA interface is at the driver level.

4:01 pm

Dara Navaei

Done

Done

1:56 pm

Sean Nash

Should this be an enum at driver level? Driver get would return enum so controller doesn't have to figure out what it means.

Should this be an enum at driver level? Driver get would return enum so controller doesn't have to figure out what it means.

1:48 pm

Sean Nash

Use U32 unless there is a good reason to use U08.

Use U32 unless there is a good reason to use U08.

1:46 pm

Sean Nash

Why bypassing driver here?

Why bypassing driver here?

1:45 pm

Sean Nash

Why are we bypassing driver here?

Why are we bypassing driver here?

1:24 pm

Sean Nash

Then your doxygen return comment looks backward.

Then your doxygen return comment looks backward.