dd-firmware

Clone Tools

Stats

Commits this week: 95
Total Committers: 15
Last Commit: 09 Feb
Commits this week: 95

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vendor - TEL - Sameer Poyil and Sean Nash

7 hrs ago

Sean Nash and Raghu Kallala

7 hrs ago

Vinayakam Mani

Done.

Done.

8 hrs ago

Michael Garthwaite

it can. removed structure and made so we send the same payload between the two message IDs

it can. removed structure and made so we send the same payload between the two message IDs

8 hrs ago

Michael Garthwaite

removed duplicate structure.

removed duplicate structure.

8 hrs ago

Sean Nash

Can't fp version use same DD structure since they are the same version?

Can't fp version use same DD structure since they are the same version?

8 hrs ago

Sean Nash

Why do we need a separate structure for same version essentially?

Why do we need a separate structure for same version essentially?

8 hrs ago

Michael Garthwaite

8 hrs ago

Vinayakam Mani

Updated.

Updated.

8 hrs ago

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

8 hrs ago

Dara Navaei

8 hrs ago

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

8 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2990_IOFP FW and FPGA version request returns None
LEAHI-DD-FIRMWARE-LDT-2990_IOFP FW and FPGA version request returns None
8 hrs ago

Sean Nash

We can but not necessary - only necessary when using == operator.

We can but not necessary - only necessary when using == operator.

8 hrs ago

Vendor - TEL - Arpita Srivastava

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

8 hrs ago

Sean Nash

In °C?

In °C?

8 hrs ago

Sean Nash

Is return value in °C? U32 is pretty low resolution for a temperature.

Is return value in °C? U32 is pretty low resolution for a temperature.

8 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

8 hrs ago

Vinayakam Mani

Done

Done

8 hrs ago

Vinayakam Mani

Done.

Done.

9 hrs ago

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

9 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

9 hrs ago

Sean Nash

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

9 hrs ago

Sean Nash

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

9 hrs ago

Sean Nash

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

9 hrs ago

Sean Nash

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().

9 hrs ago

Sean Nash

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

10 hrs ago

Vendor - TEL - Arpita Srivastava

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

11 hrs ago

Vendor - TEL - Arpita Srivastava

Please change bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE to BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

11 hrs ago

Vendor - TEL - Arpita Srivastava

Please remove extra line

Please remove extra line