dd-firmware / firmware / App

DDCommon.h

Clone Tools

Stats

Commits this week: 11
Total Committers: 9
Last Commit: 09 Feb
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Vendor - TEL - Sameer Poyil

its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

4 hrs ago

Vendor - TEL - Sameer Poyil

Now we don't need this macro ?

Now we don't need this macro ?

4 hrs ago

Vendor - TEL - Sameer Poyil

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?

4 hrs ago

Vendor - TEL - Sameer Poyil

comments missing

comments missing

4 hrs ago

Vendor - TEL - Sameer Poyil

comments missing

comments missing

4 hrs ago

Vendor - TEL - Sameer Poyil

This is not clear- please give a detailed description for this variable

This is not clear- please give a detailed description for this variable

4 hrs ago

Vendor - TEL - Sameer Poyil

use capital for starting letter

use capital for starting letter

4 hrs ago

Vendor - TEL - Sameer Poyil

please align the comments

please align the comments

4 hrs ago

Vendor - TEL - Sameer Poyil

please Alignment the comments

please Alignment the comments

4 hrs ago

Vendor - TEL - Sameer Poyil

Why the order is important here ? please document it

Why the order is important here ? please document it

4 hrs ago

Vendor - TEL - Sameer Poyil

4 hrs ago

Vendor - TEL - Sameer Poyil

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

4 hrs ago

Vendor - TEL - Sameer Poyil

Why a * here ?

Why a * here ?

5 hrs ago

Vendor - TEL - Sameer Poyil

is it write states or read state ?

is it write states or read state ?

5 hrs ago

Vendor - TEL - Sameer Poyil

is documentation correct ?

is documentation correct ?

Wednesday 08 Apr
12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:23 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:22 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:19 pm

Sean Nash

Remove blank line.

Remove blank line.

Monday 06 Apr
10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC