dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 09 Feb
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Michael Garthwaite and Vinayakam Mani

1 hr ago

Michael Garthwaite

1 hr ago

Raghu Kallala

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

2 hrs ago

Raghu Kallala

Idea is to have this in institutional records we implement it

Idea is to have this in institutional records we implement it

2 hrs ago

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

2 hrs ago

Sean Nash

If this is const, how will user add conversions (after 3rd value)?

If this is const, how will user add conversions (after 3rd value)?

2 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

2 hrs ago

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

2 hrs ago

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

2 hrs ago

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

2 hrs ago

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

2 hrs ago

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

2 hrs ago

Vinayakam Mani

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

Wednesday 29 Apr
1:49 pm

Vendor - TEL - Sameer Poyil

Tuesday 28 Apr
12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

11:20 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Monday 27 Apr
1:22 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Sunday 26 Apr
2:43 pm

Sean Nash

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

2:41 pm

Sean Nash

I think this enum should be in a different header file. I don't think this unit uses this enum.

I think this enum should be in a different header file. I don't think this unit uses this enum.

2:39 pm

Sean Nash

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

2:32 pm

Sean Nash

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

2:29 pm

Sean Nash

Do these need to be public? I think only the driver should have to know sector addresses and sizes. If other units want to know these things, they should call a function in this driver to get them.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

2:25 pm

Sean Nash

I think isSectorStartAddress is a better function name.

I think isSectorStartAddress is a better function name.

2:24 pm

Sean Nash

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thoug...

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

2:21 pm

Sean Nash

don't forget to add function headers.

don't forget to add function headers.

2:21 pm

Sean Nash

// **************** private functions **************

// **************** private functions **************