Activity td-firmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 8

Total Committers:	10
Last Commit:	25 Mar
Commits this week:	8

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

29 mins ago

Vendor - TEL - Jashwant Gantyada

More
LEAHI-TD-FIRMWARE-LDT-3126-2
finished reviewing

29 mins ago

Vendor - TEL - Jashwant Gantyada

More
LEAHI-TD-FIRMWARE-LDT-3126-2
joined review

Wednesday 25 Mar

6:46 am

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-1903-10
started review

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation

6:38 am

Vendor - TEL - Sameer Poyil

More
e0843d7
changed 1 file
LDT-1903-air-trap-level-control-dev--td---0, develop LEAHI-TD-FIRMWARE-LDT-1903-10

LDT-1903 Air Trap H12 off during fill event

- -2
- +2
./AirTrap.c
- History
- Source
- Diff
./AirTrap.c

Monday 23 Mar

5:37 pm

Vendor - TEL - Sameer Poyil

5:36 pm

Dara Navaei

More
7f3bf72
changed 1 file
LDT-1415-pressures-monitoring-td-baro, LDT-1903-air-trap-level-control-dev--td---0 and 2 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./AirTrap.c
- History
- Source
- Diff
./AirTrap.c

5:31 pm

Vendor - TEL - Sameer Poyil

More
5b25cf8
changed 1 file
LDT-1415-pressures-monitoring-td-baro, LDT-1903-air-trap-level-control-dev--td---0 and 2 more

Merge branch LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 into staging

- -8
- +34
./AirTrap.c
- History
- Source
- Diff
./AirTrap.c

10:30 am

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-1903-9
finished reviewing

10:21 am

Vendor - TEL - Sameer Poyil

More
b61fbe4
changed 1 file
LDT-1415-pressures-monitoring-td-baro, LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 and 3 more LEAHI-TD-FIRMWARE-LDT-1903-9

LDT-1903 Air Trap reverting to original valve state

- -1
- +1
./AirTrap.c
- History
- Source
- Diff
./AirTrap.c

Thursday 19 Mar

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

Tuesday 17 Mar

11:05 pm

Vendor - TEL - Sameer Poyil

reverted back

reverted back

11:05 pm

Vendor - TEL - Sameer Poyil

This code is removed and not required

This code is removed and not required

11:03 pm

Vendor - TEL - Sameer Poyil

More
8d31b20
changed 1 file
LDT-1415-pressures-monitoring-td-baro, LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 and 3 more LEAHI-TD-FIRMWARE-LDT-1903-9

LDT-1903 Air Trap Final implementation

- -26
- +31
./AirTrap.c
- History
- Source
- Diff
./AirTrap.c

9:46 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
replied to Vendor - TEL - Varshini Nagabooshanam

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:53 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:50 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:15 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3126-2
finished reviewing

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:03 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3215-1
resumed reviewing

9:58 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-2
replied to Vendor - TEL - Varshini Nagabooshanam

Wrong place.

Wrong place.

9:57 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-2
replied to Vendor - TEL - Varshini Nagabooshanam

I'll drop by and we can set properties together.

I'll drop by and we can set properties together.

Monday 16 Mar

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Sorry, Updated

Sorry, Updated

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-27 14:27 -0700