Monitors

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove the TODO comment.

Remove the TODO comment.

align the comment.

align the comment.

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

decays to threshold level (4 PSI).

decays to threshold level (4 PSI).

remove all commented code.

remove all commented code.

Update comment. remove TODO if no more applicable.

Update comment. remove TODO if no more applicable.

FillWaterEndState?

FillWaterEndState?

Delete it.

Delete it.

Supply state (instead of drain). Updates Inputs and outputs across the file.

Supply state (instead of drain). Updates Inputs and outputs across the file.

When the BC fill completed and allow opening D65 for Chamber F fill?

When the BC fill completed and allow opening D65 for Chamber F fill?

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

50ms?

50ms?

Add comment to align with the rest of the implementation.

Add comment to align with the rest of the implementation.

Add outputs as well.

Add outputs as well.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
Remove blank line.

Remove blank line.

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement.

Add blank line before return statement.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.