dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 7
Total Committers: 14
Last Commit: 20 Jan
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Monday 27 Apr
1:22 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Sunday 26 Apr
2:43 pm

Sean Nash

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

2:41 pm

Sean Nash

I think this enum should be in a different header file. I don't think this unit uses this enum.

I think this enum should be in a different header file. I don't think this unit uses this enum.

2:39 pm

Sean Nash

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

2:32 pm

Sean Nash

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

2:29 pm

Sean Nash

Do these need to be public? I think only the driver should have to know sector addresses and sizes. If other units want to know these things, they should call a function in this driver to get them.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

2:25 pm

Sean Nash

I think isSectorStartAddress is a better function name.

I think isSectorStartAddress is a better function name.

2:24 pm

Sean Nash

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thoug...

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

2:21 pm

Sean Nash

don't forget to add function headers.

don't forget to add function headers.

2:21 pm

Sean Nash

// **************** private functions **************

// **************** private functions **************

2:18 pm

Sean Nash

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

2:17 pm

Sean Nash

Add a blank line before group end marker.

Add a blank line before group end marker.

2:16 pm

Sean Nash

No load cells in Leahi.

No load cells in Leahi.

2:14 pm

Sean Nash

I think this enum belongs to NVRecords (these are records, not jobs).

I think this enum belongs to NVRecords (these are records, not jobs).

2:13 pm

Sean Nash

I think this enum belongs to the Q (these are Q jobs), not in driver.

I think this enum belongs to the Q (these are Q jobs), not in driver.

1:43 pm

Sean Nash

What about TD record CRC errors?

What about TD record CRC errors?

1:40 pm

Sean Nash

Are we only doing DD messages? And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal ...

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.

12:36 pm

Sean Nash

Declare local variables at top of scope.

Declare local variables at top of scope.

12:34 pm

Sean Nash

Add space between ( and ?

Add space between ( and ?

12:33 pm

Sean Nash

Remove blank line.

Remove blank line.

12:31 pm

Sean Nash

Why redeclare result?

Why redeclare result?

12:31 pm

Sean Nash

Remove blank line.

Remove blank line.

12:30 pm

Sean Nash

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

12:30 pm

Sean Nash

Remove blank line.

Remove blank line.

12:29 pm

Sean Nash

Remove blank line.

Remove blank line.

Friday 24 Apr
10:17 pm

Vinayakam Mani