td-firmware / firmware / App / Controllers

Ejector.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 12 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 mins ago

Sean Nash

Give ejector retract command and zero timer counter here too.

Give ejector retract command and zero timer counter here too.

3 mins ago

Sean Nash

Not needed if you do this on way out of prior state.

Not needed if you do this on way out of prior state.

3 mins ago

Sean Nash

Start BP and zero timer counter here.

Start BP and zero timer counter here.

4 mins ago

Sean Nash

Not necessary if fault property of alarm is TRUE.

Not necessary if fault property of alarm is TRUE.

4 mins ago

Sean Nash

Not necessary if you do this on way out of prior state.

Not necessary if you do this on way out of prior state.

6 mins ago

Sean Nash

Remove ejector homed stuff. Not needed.

Remove ejector homed stuff. Not needed.

6 mins ago

Sean Nash

Give eject cmd and zero timer counter here.

Give eject cmd and zero timer counter here.

6 mins ago

Sean Nash

give BP home command and zero timer counter here.

give BP home command and zero timer counter here.

10 mins ago

Sean Nash

Not necessary. Just make alarm have fault property = TRUE.

Not necessary. Just make alarm have fault property = TRUE.

11 mins ago

Sean Nash

Again, ejector should have been retracted way back in pre-treatment mode. We shouldn't need to do it again.

Again, ejector should have been retracted way back in pre-treatment mode. We shouldn't need to do it again.

13 mins ago

Sean Nash

Shouldn't need this if statement. If we timeout, we want to stop the pump and alarm.

Shouldn't need this if statement. If we timeout, we want to stop the pump and alarm.

14 mins ago

Sean Nash

Better to home BP on your way out of previous state so you don't have to use a cmd issued flag. Ejector should already be retracted, so I see no reason to home the ejector here. You should also zer...

Better to home BP on your way out of previous state so you don't have to use a cmd issued flag.
Ejector should already be retracted, so I see no reason to home the ejector here.
You should also zero the autoEjectTimerCounter too.

18 mins ago

Sean Nash

Not necessary to request fault mode. Just set alarm fault property to TRUE.

Not necessary to request fault mode. Just set alarm fault property to TRUE.

18 mins ago

Sean Nash

This is way too late. UI s/w expects response immediately (so always send it in message handler function.)

This is way too late. UI s/w expects response immediately (so always send it in message handler function.)

19 mins ago

Sean Nash

rejectionReason should be set to none (zero) here too.

rejectionReason should be set to none (zero) here too.

20 mins ago

Sean Nash

You should send response regardless of success - so I think this should be moved to the very end of the function, outside of any if statements so that it always responds. You should set accept flag...

You should send response regardless of success - so I think this should be moved to the very end of the function, outside of any if statements so that it always responds. You should set accept flag and reject reason codes in these if statements so the response that gets sent will have the correct payload.

23 mins ago

Sean Nash

Declare locals at top of scope (so before memcpy). Also, when assigning to a BOOL, be explicit (i.e. TRUE or FALSE). You can use a ternary operation for this (e.g. BOOL b = <bool expr> ? TRUE : FAL...

Declare locals at top of scope (so before memcpy).
Also, when assigning to a BOOL, be explicit (i.e. TRUE or FALSE).
You can use a ternary operation for this (e.g. BOOL b = <bool expr> ? TRUE : FALSE

25 mins ago

Sean Nash

Does this message need a BOOL? Will UI ever send this message with a FALSE? Check with Nico on this.

Does this message need a BOOL? Will UI ever send this message with a FALSE? Check with Nico on this.

28 mins ago

Sean Nash

Add a space before )

Add a space before )

29 mins ago

Sean Nash

Set the fault property for this alarm to TRUE and then you don't need to request to go to fault mode - the alarm will do it for you. You should never have to request fault mode like this.

Set the fault property for this alarm to TRUE and then you don't need to request to go to fault mode - the alarm will do it for you. You should never have to request fault mode like this.

32 mins ago

Sean Nash

Add a blank line after declaration(s) for a little separation.

Add a blank line after declaration(s) for a little separation.

35 mins ago

Sean Nash

Need function header above function.

Need function header above function.

Monday 20 Apr
11:02 am

Sean Nash

Need unique s/w malf id.

Need unique s/w malf id.

10:26 am

Sean Nash

Is this right?

Is this right?

10:24 am

Sean Nash

Align =

Align =

10:22 am

Sean Nash

Should be in Ejector.c

Should be in Ejector.c

Friday 10 Apr
11:46 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD
LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD
Monday 19 Jan
5:08 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Ejector.h
  2. … 96 more files in changeset.
Friday 19 Dec 2025
1:57 pm

Dara Navaei

1:51 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Ejector.h
  2. … 15 more files in changeset.