dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 22
Total Committers: 15
Last Commit: 22 Feb
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 22 Feb
5:12 pm

Vendor - TEL - Sameer Poyil

LDT-2004 removed the blank line

Options
    • -1
    • +0
    ./Controllers/BalancingChamber.c
5:04 pm

Vendor - TEL - Sameer Poyil

LDT-2004 Rearranged the code after the restructuring was misplaced

Options
    • -4
    • +7
    ./Controllers/BalancingChamber.c
Friday 20 Feb
5:07 pm

Dara Navaei

3:12 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
3:12 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Valves.h
    • -2
    • +2
    ./Drivers/BloodLeakDriver.h
3:01 pm

Vendor - TEL - Jashwant Gantyada

3:00 pm

Vinayakam Mani and Sean Nash

2:46 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

2:41 pm

Sean Nash

2:19 pm

Vendor - TEL - Sameer Poyil

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

2:17 pm

Vendor - TEL - Sameer Poyil

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

1:42 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:42 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

1:41 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

12:50 pm

Raghu Kallala

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

11:03 am

Sean Nash

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6). We still need test configs for beta 1.0 stuff and non-fpga differences. We can use DD fpga ID # here in this macro instead of t...

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

10:22 am

Sean Nash

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff. I agree, but didn't comm...

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

9:59 am

Sean Nash

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

9:46 am

Sean Nash

Move this up to public definitions section.

Move this up to public definitions section.

9:41 am

Sean Nash

These don't need to be initialized.

These don't need to be initialized.

9:17 am

Sean Nash

Outputs is none now I think.

Outputs is none now I think.

7:59 am

Raghu Kallala

readFloaterLevelStatus is higher level functions that give the data from the FPGA. Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandab...

readFloaterLevelStatus is higher level functions that give the data from the FPGA.
Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandable enum values (low, medium, high)

7:55 am

Raghu Kallala

This is a reset call, as the default requirement is to be on Beta 1.9 HW The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA r...

This is a reset call, as the default requirement is to be on Beta 1.9 HW
The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA registers

1:05 am

Vendor - TEL - Sameer Poyil

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cas...

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cases instead of multiple functions.

12:29 am

Vendor - TEL - Sameer Poyil

Its not required, HW should be auto detected and initialized without any user configuration.

Its not required, HW should be auto detected and initialized without any user configuration.

12:25 am

Vendor - TEL - Sameer Poyil

why its checking beta 2 and then setting beta 1.9 HW ?

why its checking beta 2 and then setting beta 1.9 HW ?

12:22 am

Vendor - TEL - Sameer Poyil

We don't need this complex logic . use getFPGAVersions() function

We don't need this complex logic . use getFPGAVersions() function

12:18 am

Vendor - TEL - Sameer Poyil

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0

12:16 am

Vendor - TEL - Sameer Poyil

why do we need #if 1 here ?

why do we need #if 1 here ?

Thursday 19 Feb
4:43 pm

Vendor - TEL - Jashwant Gantyada

done. Please check if you are looking at the latest commit.

done. Please check if you are looking at the latest commit.