dd-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 9
Total Committers: 15
Last Commit: 06 Mar
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Mar
2:48 pm

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

2:46 pm

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

2:42 pm

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

2:38 pm

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

2:37 pm

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

2:36 pm

Sean Nash

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

2:34 pm

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

12:47 pm

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

12:37 pm

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

9:58 am

Michael Garthwaite

Yes since you're not using the return value in execOpModes()

Yes since you're not using the return value in execOpModes()

Thursday 05 Mar
7:32 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
Wednesday 04 Mar
2:05 pm

Sean Nash

Looked better before - now misspelled.

Looked better before - now misspelled.

2:04 pm

Sean Nash

0.0F

0.0F

2:04 pm

Sean Nash

indent looks 1 space off.

indent looks 1 space off.

2:01 pm

Sean Nash

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

2:00 pm

Sean Nash

Declare at top of scope, assign down here if needed.

Declare at top of scope, assign down here if needed.

1:59 pm

Sean Nash

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

1:57 pm

Sean Nash

Remove blank line.

Remove blank line.

1:56 pm

Sean Nash

Which heater does single target temp apply to? Or does same target apply to both heaters?

Which heater does single target temp apply to? Or does same target apply to both heaters?

1:53 pm

Sean Nash

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

1:51 pm

Sean Nash

Remove blank line.

Remove blank line.

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:51 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:50 pm

Sean Nash

return should be "none"

return should be "none"

1:49 pm

Sean Nash

Why 2 inputs?

Why 2 inputs?

1:49 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:49 pm

Sean Nash

Do we really need 64 bits for this?

Do we really need 64 bits for this?

1:46 pm

Sean Nash

Remove blank line.

Remove blank line.

1:45 pm

Sean Nash

Add blank line after private data banner.

Add blank line after private data banner.