leahi-fwcommon

Comm.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 03 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Feb
11:37 am

Michael Garthwaite

11:01 am

Sean Nash

10:37 am

Michael Garthwaite

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:21 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /Comm.c
  2. … 1 more file in changeset.
Tuesday 27 Jan
1:03 pm

Michael Garthwaite

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

12:34 pm

Sean Nash

I think using filtered values for alarms makes sense.

I think using filtered values for alarms makes sense.

10:25 am

Michael Garthwaite

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want...

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want a sample point.

in Denali, looks like the HD got the filtered temperature value from the DG for checking dialysate temp alarms. Are we upholding that same design of using a filtered value for leahi dialysate temp?

10:22 am

Michael Garthwaite

LDT-2004: code review updates

Options
    • -2
    • +4
    /Comm.c
  2. … 1 more file in changeset.
10:19 am

Sean Nash

I don't see fix. Did you push fwcommon?

I don't see fix. Did you push fwcommon?

10:15 am

Sean Nash

Restore this blank line.

Restore this blank line.

10:15 am

Sean Nash

Remove all of these blank lines please.

Remove all of these blank lines please.

10:03 am

Michael Garthwaite

Removed the ifdef here as these overrides still be used without breaking the teensy driver. I can add it on request. Unsure if teensy will be tested long enough for them to use those overrides. In...

Removed the ifdef here as these overrides still be used without breaking the teensy driver.
I can add it on request. Unsure if teensy will be tested long enough for them to use those overrides.

In the meantime,

MSG_ID_DD_FILTERED_COND_SENSOR_READINGS_OVERRIDE_REQUEST and MSG_ID_FP_FILTERED_COND_SENSOR_READINGS_OVERRIDE_REQUEST are still available to override the monitor/filtered data.

9:57 am

Michael Garthwaite

fixed.

fixed.

9:57 am

Michael Garthwaite

fixed.

fixed.

9:57 am

Michael Garthwaite

Not here. This include was not in the right spot as we want the two drivers to be separated. the include is in the monitor

Not here. This include was not in the right spot as we want the two drivers to be separated. the include is in the monitor

9:50 am

Michael Garthwaite

Temperature monitor only has getter's for d4 and d50 at the moment. It looks like that hasnt been refactored to consider all temp sensors.

Temperature monitor only has getter's for d4 and d50 at the moment. It looks like that hasnt been refactored to consider all temp sensors.

9:38 am

Michael Garthwaite

for Teensy it is done at the driver as it is a part of the initialization sequence. See TEENSY_CMD_GET_EEPROM_DATA cmd.

for Teensy it is done at the driver as it is a part of the initialization sequence. See TEENSY_CMD_GET_EEPROM_DATA cmd.

9:30 am

Michael Garthwaite

Not at the moment. This feature isnt expected to on the V2's. The v2's arent going to have ALY_LINEAR as that is one specific to the teensy sensors.

Not at the moment. This feature isnt expected to on the V2's. The v2's arent going to have ALY_LINEAR as that is one specific to the teensy sensors.

Monday 26 Jan
10:31 pm

Sean Nash

#ifdef TEENSY for these new functions.

#ifdef TEENSY for these new functions.

10:31 pm

Sean Nash

Only needed for TEENSY, right? So #ifdef should be applied.

Only needed for TEENSY, right? So #ifdef should be applied.

10:30 pm

Sean Nash

No model selection for V2 sensor?

No model selection for V2 sensor?

10:29 pm

Sean Nash

Teensy driver doesn't need overrides too?

Teensy driver doesn't need overrides too?

10:27 pm

Sean Nash

Probably shouldn't have "TEENSY" in the name. Non-teensy driver will probably need this too, so can be generic.

Probably shouldn't have "TEENSY" in the name. Non-teensy driver will probably need this too, so can be generic.

10:25 pm

Sean Nash

Is calibration going to be done here or at driver? I was expecting driver to calibrate since cal factors are coming from sensor.

Is calibration going to be done here or at driver? I was expecting driver to calibrate since cal factors are coming from sensor.

10:23 pm

Sean Nash

Remove blank line.

Remove blank line.

10:22 pm

Sean Nash

Should we have #ifdef here to determine which driver to initialize?

Should we have #ifdef here to determine which driver to initialize?

10:20 pm

Sean Nash

If we're not using filtered values, why filter them at all?

If we're not using filtered values, why filter them at all?

10:15 pm

Sean Nash

Add comments to right.

Add comments to right.

10:13 pm

Sean Nash

enum should have a /// comment on top.

enum should have a /// comment on top.

10:12 pm

Sean Nash

Shouldn't D27 temp be gotten from monitor (Temperature.c) instead of from conductivity drivers?

Shouldn't D27 temp be gotten from monitor (Temperature.c) instead of from conductivity drivers?