Activity leahi-common/MsgDefs.h

6 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
replied to Vendor - TEL - Varshini Nagabooshanam

Still need to range check the rate, reject if out of range, accept and assign if in range.

6 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
replied to Vendor - TEL - Varshini Nagabooshanam

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Assigned to local variable

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated to else part

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated

12 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
replied to Vendor - TEL - Varshini Nagabooshanam

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we a...

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we assign new rate to your static variable.

12 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

I think this can just be an else since resume is the only remaining possibility.

12 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

12 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
replied to Vendor - TEL - Varshini Nagabooshanam

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

12 hrs ago