leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
remove spaces before =

remove spaces before =

change accordingly

change accordingly

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

test instead of handle

test instead of handle

Align =

Align =

Should modality be an enum type?

Should modality be an enum type?

Align =

Align =

Should this be an enum type?

Should this be an enum type?

You also need to add these to the ALARM_RANK_TABLE (the table sorted by rank).

You also need to add these to the ALARM_RANK_TABLE (the table sorted by rank).

Can we be a little more specific about what conductivity we are returning in these functions? And I think we should include constants in the Inputs section of function headers.

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

Should the word "GENERIC" be in here somewhere?

Should the word "GENERIC" be in here somewhere?