FpgaTD.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Updated

Updated

Added

Added

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

Updated

Updated

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

Added

Added

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Added

Added

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

done updated below in the function as well.

done updated below in the function as well.

done.

done.

Intentional?

Intentional?

update the header and field comments in later commits

update the header and field comments in later commits

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

blank line before return.

blank line before return.

Blank line after declarations.

Blank line after declarations.

done.

done.

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

handled accordingly.

handled accordingly.

removed and added.

removed and added.

fixed in latest code

fixed in latest code

implemented

implemented

fixed

fixed