td-firmware / firmware / App / Modes

ModeTreatment.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 12 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
4:23 pm

Vendor - TEL - Varshini Nagabooshanam

4:21 pm

Vendor - TEL - Sameer Poyil and Sean Nash

4:21 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
Thursday 05 Mar
1:49 pm

Sean Nash

blank line before return.

blank line before return.

1:49 pm

Sean Nash

Blank line after declarations.

Blank line after declarations.

Tuesday 03 Mar
4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:35 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

4:35 pm

Sean Nash

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we shoul...

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state.
if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Updated

Yes, Updated

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Replaced

Replaced

2:11 pm

Sean Nash

This should be invalid state (or something like that).

This should be invalid state (or something like that).

2:11 pm

Sean Nash

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

2:08 pm

Sean Nash

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

2:07 pm

Sean Nash

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

10:59 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 02 Mar
4:41 pm

Sean Nash

Still need to range check the rate, reject if out of range, accept and assign if in range.

Still need to range check the rate, reject if out of range, accept and assign if in range.

4:26 pm

Sean Nash

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Assigned to local variable

Assigned to local variable

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Updated to else part

Updated to else part

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

2:51 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:18 am

Sean Nash

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we a...

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we assign new rate to your static variable.

10:15 am

Sean Nash

I think this can just be an else since resume is the only remaining possibility.

I think this can just be an else since resume is the only remaining possibility.

10:10 am

Sean Nash

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

9:59 am

Sean Nash

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

9:56 am

Sean Nash

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.