dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

close D80, D64, D14?

close D80, D64, D14?

D80 : open, D65: Close?

D80 : open, D65: Close?

I'm seeing a lot of magic numbers. We should have #defines for these values.

I'm seeing a lot of magic numbers. We should have #defines for these values.

Add doxygen comments to right.

Add doxygen comments to right.

LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-4022_Disinfection (DD heat, heat+descale) - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4022_Disinfection (DD heat, heat+descale) - FW Implementation - 1/4:
The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

removed

removed

updated

updated

updated

updated

updated

updated

removed

removed

Are we done testing? Can we remote test variables and code?

Are we done testing? Can we remote test variables and code?

Remove Sequence step states if not being used.

Remove Sequence step states if not being used.

Update comments ( remove start/end states)

Update comments ( remove start/end states)

Update TD to DD.

Update TD to DD.

Update alarm properties (DD fault, Priority eti,.)

Update alarm properties (DD fault, Priority eti,.)

Remove the empty line.

Remove the empty line.

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Remove commented code.

Remove commented code.

Remove D34 valve close.

Remove D34 valve close.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

void inside paranthesis.

void inside paranthesis.