dd-firmware / firmware / App / Services

AlarmMgmtSWFaults.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 11
Last Commit: 13:17
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 04 Jun
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
Monday 01 Jun
1:47 pm

Vinayakam Mani

Update alarms and Input/Output sections.

Update alarms and Input/Output sections.

1:41 pm

Vinayakam Mani

Also, add option individual parameter override for substitutions pump rate as well.

Also, add option individual parameter override for substitutions pump rate as well.

1:39 pm

Vinayakam Mani

Space after parenthesis. Please add the same in else portion as well (when treatment is in progress, update the rate).

Space after parenthesis. Please add the same in else portion as well (when treatment is in progress, update the rate).

12:43 pm

Michael Garthwaite

fixed.

fixed.

12:43 pm

Michael Garthwaite

fixed

fixed

12:43 pm

Michael Garthwaite

fixed

fixed

12:43 pm

Michael Garthwaite

fixed

fixed

12:43 pm

Michael Garthwaite

added

added

Friday 29 May
6:29 pm

Vinayakam Mani

6:29 pm

Vinayakam Mani

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

6:25 pm

Vinayakam Mani

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

6:20 pm

Vinayakam Mani

Substitution pump

Substitution pump

2:03 pm

Vinayakam Mani

Missing comment.

Missing comment.

2:01 pm

Vinayakam Mani

update comment. next one as well.

update comment. next one as well.

2:00 pm

Vinayakam Mani

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

11:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
Thursday 28 May
1:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Wednesday 27 May
4:24 pm

Dara Navaei

3:43 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AlarmMgmtSWFaults.h
  2. … 7 more files in changeset.
3:38 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:46 pm

Sean Nash

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop si...

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

2:39 pm

Sean Nash

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch...

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

2:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:31 pm

Sean Nash

Where is call to HDF controller?

Where is call to HDF controller?

2:31 pm

Sean Nash

Monitors should come before mode mgmt above.

Monitors should come before mode mgmt above.

2:30 pm

Sean Nash

What about HemoDiaFiltration.h?

What about HemoDiaFiltration.h?

2:29 pm

Sean Nash

What about initHDF?

What about initHDF?

2:28 pm

Sean Nash

Where is HemoDiaFiltration.h?

Where is HemoDiaFiltration.h?

2:24 pm

Sean Nash

Why does this file name have pound signs pre/post?

Why does this file name have pound signs pre/post?