dd-firmware / firmware / App / Monitors

Temperature.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 9
Last Commit: 16 Jan
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
10 hrs ago

Vendor - TEL - Sameer Poyil

its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

10 hrs ago

Vendor - TEL - Sameer Poyil

Now we don't need this macro ?

Now we don't need this macro ?

11 hrs ago

Vendor - TEL - Sameer Poyil

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?

11 hrs ago

Vendor - TEL - Sameer Poyil

comments missing

comments missing

11 hrs ago

Vendor - TEL - Sameer Poyil

comments missing

comments missing

11 hrs ago

Vendor - TEL - Sameer Poyil

This is not clear- please give a detailed description for this variable

This is not clear- please give a detailed description for this variable

11 hrs ago

Vendor - TEL - Sameer Poyil

use capital for starting letter

use capital for starting letter

11 hrs ago

Vendor - TEL - Sameer Poyil

please align the comments

please align the comments

11 hrs ago

Vendor - TEL - Sameer Poyil

please Alignment the comments

please Alignment the comments

11 hrs ago

Vendor - TEL - Sameer Poyil

Why the order is important here ? please document it

Why the order is important here ? please document it

11 hrs ago

Vendor - TEL - Sameer Poyil

11 hrs ago

Vendor - TEL - Sameer Poyil

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

11 hrs ago

Vendor - TEL - Sameer Poyil

Why a * here ?

Why a * here ?

11 hrs ago

Vendor - TEL - Sameer Poyil

is it write states or read state ?

is it write states or read state ?

11 hrs ago

Vendor - TEL - Sameer Poyil

is documentation correct ?

is documentation correct ?

Wednesday 08 Apr
12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:23 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:22 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:19 pm

Sean Nash

Remove blank line.

Remove blank line.

12:11 pm

Sean Nash

Why are we switching sensors around?

Why are we switching sensors around?

12:11 pm

Sean Nash

Why D43?

Why D43?

12:10 pm

Sean Nash

Remove blank line.

Remove blank line.

12:09 pm

Sean Nash

Should we be filtering a new sample every 700ms or should we do it when a new sample is received? FPGA is giving us a read count right? So we will know when we have a new data set from sensor. It m...

Should we be filtering a new sample every 700ms or should we do it when a new sample is received?
FPGA is giving us a read count right? So we will know when we have a new data set from sensor. It makes more sense to me to take them when they come. Otherwise, we will get out of phase with true sample frequency and occasionally process the previous sample again (if true sample freq is a little slower than 700ms) or miss a sample (if true sample freq is a little faster than 700ms).

12:04 pm

Sean Nash

Why do we need these static interval variables when we have the constants?

Why do we need these static interval variables when we have the constants?

12:03 pm

Sean Nash

Remove blank line.

Remove blank line.

Monday 06 Apr
10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.