dd-firmware / firmware / App

Tasks

Clone Tools

Stats

Commits this week: 2
Total Committers: 10
Last Commit: 27 May
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

5 hrs ago

Dara Navaei and Vinayakam Mani

9 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
Thursday 06 Aug
2:16 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5357_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 9/1:
LEAHI-DD-FIRMWARE-LDT-5357_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 9/1:
Monday 03 Aug
11:05 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Thursday 30 Jul
7:14 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

updated now

updated now

11:23 am

Vendor - TEL - Arpita Srivastava

10:23 am

Sean Nash

Wednesday 29 Jul
5:37 pm

Dara Navaei

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
Tuesday 28 Jul
4:38 pm

Vendor - TEL - Arpita Srivastava

Monday 27 Jul
10:06 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

3:58 pm

Sean Nash

keep a blank line between declaration(s) and code.

keep a blank line between declaration(s) and code.

3:57 pm

Sean Nash

If level can be overridden, you should use get function.

If level can be overridden, you should use get function.

3:55 pm

Sean Nash

Add blank line before banner.

Add blank line before banner.

2:29 pm

Vinayakam Mani and Sean Nash

11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Friday 24 Jul
10:11 am

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

10:07 am

Vinayakam Mani

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)