ModeGenDialysate.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FALSE?

FALSE?

FALSE?

FALSE?

FALSE?

FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

Delete the macro if not being used.

Delete the macro if not being used.

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

removed

removed

updated comment.

updated comment.

removed.

removed.

removed and added comments.

removed and added comments.

changed.

changed.

done. moved them to dosing concentrates state.

done. moved them to dosing concentrates state.

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
Not sure these min/max are right here either.

Not sure these min/max are right here either.

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

Remove extra blank lines.

Remove extra blank lines.

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

Update the deadband timing in the comments.

Update the deadband timing in the comments.

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.

Default case rise count should be 2, instead of 1?

Default case rise count should be 2, instead of 1?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

Done.

Done.

Done

Done

Done.

Done.