dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine ...

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

This code looks very similar to bicarb code above. Do we really need separate handling?

This code looks very similar to bicarb code above. Do we really need separate handling?

Updated

Updated

Remove extra blank line.

Remove extra blank line.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1:
LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1:
fixed

fixed

Align the comments.

Align the comments.

LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.

0.0F is made by Sean.

0.0F is made by Sean.

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)