dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 20
Total Committers: 13
Last Commit: 19 Feb
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Apr
12:25 pm

Vendor - TEL - Sameer Poyil

12:14 pm

Vinayakam Mani and Sean Nash

10:18 am

Vinayakam Mani

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Tuesday 28 Apr
9:42 pm

Vendor - TEL - Sameer Poyil

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

11:05 am

Vinayakam Mani

Do we need to check if bicarb chamber level is high, ignore opening D80?

Do we need to check if bicarb chamber level is high, ignore opening D80?

11:01 am

Vinayakam Mani

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

9:17 am

Vinayakam Mani

Align comment

Align comment

9:16 am

Vinayakam Mani

Add comment.

Add comment.

Monday 27 Apr
1:22 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Sunday 26 Apr
12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

12:36 pm

Sean Nash

Declare local variables at top of scope.

Declare local variables at top of scope.

12:34 pm

Sean Nash

Add space between ( and ?

Add space between ( and ?

12:33 pm

Sean Nash

Remove blank line.

Remove blank line.

12:31 pm

Sean Nash

Why redeclare result?

Why redeclare result?

12:31 pm

Sean Nash

Remove blank line.

Remove blank line.

12:30 pm

Sean Nash

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

12:30 pm

Sean Nash

Remove blank line.

Remove blank line.

12:29 pm

Sean Nash

Remove blank line.

Remove blank line.

Friday 24 Apr
10:17 pm

Vinayakam Mani

Thursday 23 Apr
2:59 pm

Vinayakam Mani

2:57 pm

Vinayakam Mani

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

2:49 pm

Vinayakam Mani

lower? and change the D98 level sensor comment as well.

lower? and change the D98 level sensor comment as well.

2:47 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:46 pm

Vinayakam Mani

Space before LVL_STATE_LOW

Space before LVL_STATE_LOW

2:44 pm

Vinayakam Mani

space inside array index.

space inside array index.