FpgaTD.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command m...

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command message handlers like these.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

We will not have this saline bolus state in Leahi.

We will not have this saline bolus state in Leahi.

This code review contains known issues, and it is not yet ready for a detailed review.

This code review contains known issues, and it is not yet ready for a detailed review.

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation
We tend to initialize the local variables as a standard practice.

We tend to initialize the local variables as a standard practice.

These don't need to be initialized to zero.

These don't need to be initialized to zero.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done.

Done.

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

Declarations should be at top of scope.

Declarations should be at top of scope.

Is this temporary?

Is this temporary?

Done

Done

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Done

Done

move static function after public function

move static function after public function

let public function on top

let public function on top

Let all public functions come on top for all files

Let all public functions come on top for all files

Should we comment this out before merging?

Should we comment this out before merging?

Done

Done