td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 30
Total Committers: 13
Last Commit: 20 Feb
Commits this week: 30

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb
1:49 pm

Sean Nash

1:48 pm

Sean Nash

1:45 pm

Sean Nash

This is a msg payload structure. Even though all fields are 4 bytes, we should still pack it in case we add smaller fields later.

This is a msg payload structure. Even though all fields are 4 bytes, we should still pack it in case we add smaller fields later.

1:42 pm

Raghu Kallala

Updated

Updated

1:36 pm

Raghu Kallala

Updated

Updated

1:35 pm

Sean Nash

I think this function should be in ModeTreatment or Messaging.

I think this function should be in ModeTreatment or Messaging.

1:34 pm

Sean Nash

update params in header.

update params in header.

1:34 pm

Raghu Kallala

you are right, I missed it here. Fixed.

you are right, I missed it here.
Fixed.

1:33 pm

Sean Nash

Move pop to be right after last structure to be packed.

Move pop to be right after last structure to be packed.

1:28 pm

Sean Nash

I thought acid fields were F32?

I thought acid fields were F32?

1:14 pm

Sean Nash

Update inputs/outputs after updating function.

Update inputs/outputs after updating function.

1:14 pm

Sean Nash

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run sta...

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run state (whichever state we were in when we paused).

1:14 pm

Sean Nash

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state). We also need to look for user request to pause (same as in ramp state).

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state).
We also need to look for user request to pause (same as in ramp state).

1:12 pm

Sean Nash

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymor...

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymore. Ask Nico which message UI sends when user changes blood flow rate.

And we need another else if for when user asks to pause blood prime and we would stop BP (and maybe close art/ven pinch valves) and go to pause state.

1:10 pm

Sean Nash

Input and Output is cumulativeBloodPrimevolume_mL.

Input and Output is cumulativeBloodPrimevolume_mL.

1:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

1:07 pm

Sean Nash

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow r...

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow rate which they have not done here.

1:05 pm

Sean Nash

Raghu is fixing this in his Tx Params branch, but you should fix it too. TUBING_BLOOD_PRIME_VOLUME_ML is not a treatment parameter. See Raghu's fix and duplicate it here.

Raghu is fixing this in his Tx Params branch, but you should fix it too. TUBING_BLOOD_PRIME_VOLUME_ML is not a treatment parameter. See Raghu's fix and duplicate it here.

1:02 pm

Sean Nash

But now it's not in right position (in this table only). This table should be sorted by rank.

But now it's not in right position (in this table only). This table should be sorted by rank.

12:49 pm

Sean Nash

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
12:41 pm

Raghu Kallala

removed both enums

removed both enums

12:38 pm

Raghu Kallala

12:28 pm

Dara Navaei and Sean Nash

12:13 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:12 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:37 am

Sean Nash

This was correct before (assuming 711 was correct rank).

This was correct before (assuming 711 was correct rank).

11:36 am

Sean Nash

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

11:32 am

Sean Nash

In comment, specify units is % duty cycle (0..100%).

In comment, specify units is % duty cycle (0..100%).

11:31 am

Sean Nash

Should we specify that power level is now a duty cycle percentage (0..100%)?

Should we specify that power level is now a duty cycle percentage (0..100%)?